790593 - Allow to register a listener for profiler start/stop events

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Allow to register a listener for profiler start/stop events

Comment 2

[Benoit Girard (:BenWa)]

Comment on attachment 660399 [details] [diff] [review]
Allow to register a listener for profiler start/stop events

Review of attachment 660399 [details] [diff] [review]:
-----------------------------------------------------------------

What do you think of exposing AddObserver to the IDL ehsan? I can see other occurrences in the code but I'm not certain it's much of a saver since the script still needs to know about all the events it cares about.

::: tools/profiler/nsIProfiler.idl
@@ +10,1 @@
>  [scriptable, uuid(e388fded-1321-41af-a988-861a2bc5cfc3)]

Update the uuid.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Allow to register a listener for profiler start/stop events

Updated uuid.

Comment 4

[(no longer active)]

Comment on attachment 660409 [details] [diff] [review]
Allow to register a listener for profiler start/stop events

Review of attachment 660409 [details] [diff] [review]:
-----------------------------------------------------------------

We usually don't add AddObserver/RemoveObserver methods like this unless the object handles notifying the observers itself.  For the purpose of this bug, you can just use the observer service (as you currently do) and let the observers register with the observer service directly.

Also, for consistency with most other notifications, I'd prefer topic names such as profiler-started, etc.

Comment 5

[Mike Hommey [:glandium]]

Attachment: Notify when the profiler starts and stops through the observer service

Also moved where the notifications are sent, so that they are not emitted, e.g, when the profiler is stopped and stopProfiler is called.

Comment 6

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5543e5e5bcd3

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5543e5e5bcd3