don't use atoi() for 64bit ASCII to number conversion

RESOLVED FIXED in mozilla18

Status

()

Core
Networking
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

({dev-doc-needed})

Trunk
mozilla18
x86
Windows 7
dev-doc-needed
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Some code for Content-Length and Range still uses atoi()...
Created attachment 660417 [details] [diff] [review]
fix
Assignee: nobody → m_kato
Comment on attachment 660417 [details] [diff] [review]
fix

Should I change 3rd parameter of nsIUploadChannel.setUploadStream to 64-bit?
Attachment #660417 - Flags: review?(honzab.moz)
yes please!
(Assignee)

Updated

5 years ago
Attachment #660417 - Flags: review?(honzab.moz)
Created attachment 662060 [details] [diff] [review]
Part 1 - setUploadStream can handle 64-bit length
Attachment #660417 - Attachment is obsolete: true
Created attachment 662061 [details] [diff] [review]
Part 2 - don't use atoi to parse header
(Assignee)

Updated

5 years ago
Attachment #662060 - Flags: review?(honzab.moz)
(Assignee)

Updated

5 years ago
Attachment #662061 - Flags: review?(honzab.moz)
Attachment #662060 - Flags: review?(honzab.moz) → review+
Attachment #662061 - Flags: review?(honzab.moz) → review+
Attachment #662061 - Attachment description: Part 2 - don't use aoti to parse header → Part 2 - don't use atoi to parse header
https://hg.mozilla.org/integration/mozilla-inbound/rev/df2fbeb72ca1
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d6537a47627
Target Milestone: --- → mozilla18
Thanks Christian for the reviews.
https://hg.mozilla.org/mozilla-central/rev/df2fbeb72ca1
https://hg.mozilla.org/mozilla-central/rev/2d6537a47627
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Keywords: dev-doc-needed
Depends on: 803713
You need to log in before you can comment on or make changes to this bug.