Last Comment Bug 790617 - don't use atoi() for 64bit ASCII to number conversion
: don't use atoi() for 64bit ASCII to number conversion
Status: RESOLVED FIXED
: dev-doc-needed
Product: Core
Classification: Components
Component: Networking (show other bugs)
: Trunk
: x86 Windows 7
: -- normal (vote)
: mozilla18
Assigned To: Makoto Kato [:m_kato]
:
Mentors:
Depends on: 803713
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-12 07:09 PDT by Makoto Kato [:m_kato]
Modified: 2012-12-17 11:19 PST (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (3.62 KB, patch)
2012-09-12 07:09 PDT, Makoto Kato [:m_kato]
no flags Details | Diff | Splinter Review
Part 1 - setUploadStream can handle 64-bit length (5.03 KB, patch)
2012-09-18 00:49 PDT, Makoto Kato [:m_kato]
cbiesinger: review+
Details | Diff | Splinter Review
Part 2 - don't use atoi to parse header (3.33 KB, patch)
2012-09-18 00:50 PDT, Makoto Kato [:m_kato]
cbiesinger: review+
Details | Diff | Splinter Review

Description Makoto Kato [:m_kato] 2012-09-12 07:09:02 PDT
Some code for Content-Length and Range still uses atoi()...
Comment 1 Makoto Kato [:m_kato] 2012-09-12 07:09:47 PDT
Created attachment 660417 [details] [diff] [review]
fix
Comment 2 Makoto Kato [:m_kato] 2012-09-12 07:11:30 PDT
Comment on attachment 660417 [details] [diff] [review]
fix

Should I change 3rd parameter of nsIUploadChannel.setUploadStream to 64-bit?
Comment 3 Christian :Biesinger (don't email me, ping me on IRC) 2012-09-12 10:48:15 PDT
yes please!
Comment 4 Makoto Kato [:m_kato] 2012-09-18 00:49:35 PDT
Created attachment 662060 [details] [diff] [review]
Part 1 - setUploadStream can handle 64-bit length
Comment 5 Makoto Kato [:m_kato] 2012-09-18 00:50:36 PDT
Created attachment 662061 [details] [diff] [review]
Part 2 - don't use atoi to parse header
Comment 7 Honza Bambas (:mayhemer) 2012-09-19 06:13:10 PDT
Thanks Christian for the reviews.

Note You need to log in before you can comment on or make changes to this bug.