790617 - don't use atoi() for 64bit ASCII to number conversion

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Makoto Kato [:m_kato]]

Some code for Content-Length and Range still uses atoi()...

Comment 1

[Makoto Kato [:m_kato]]

Attachment: fix

Comment 2

[Makoto Kato [:m_kato]]

Comment on attachment 660417 [details] [diff] [review]
fix

Should I change 3rd parameter of nsIUploadChannel.setUploadStream to 64-bit?

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

yes please!

Comment 4

[Makoto Kato [:m_kato]]

Attachment: Part 1 - setUploadStream can handle 64-bit length

Comment 5

[Makoto Kato [:m_kato]]

Attachment: Part 2 - don't use atoi to parse header

Comment 6

[Makoto Kato [:m_kato]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/df2fbeb72ca1
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d6537a47627

Comment 7

[Honza Bambas (:mayhemer)]

Thanks Christian for the reviews.

Comment 8

[Graeme McCutcheon [:graememcc]]

https://hg.mozilla.org/mozilla-central/rev/df2fbeb72ca1
https://hg.mozilla.org/mozilla-central/rev/2d6537a47627