790639 - Make TBPL recognise "Output exceeded N bytes, remaining output has been truncated"

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Ed Morley [:emorley]]

The string is from:
http://hg.mozilla.org/build/buildbot/file/f9241cc171ad/master/buildbot/status/builder.py#l471

Given that aiui we're not supposed to patch the buildbot repo directly, this would just be a lot more easily dealt with in TBPL (than trying to mess about with buildbotcustom).

Comment 1

[Ed Morley [:emorley]]

Attachment: Patch v1

I didn't know if "^Output exceeded" would hit false positives, so added a bit more from the string.

Comment 2

[Phil Ringnalda (:philor)]

Comment on attachment 660450 [details] [diff] [review]
Patch v1

If someone triggers it as a false positive, that's a sign that they need to not use phrases from my nightmares.

Comment 3

[Ed Morley [:emorley]]

Thank you for the review :-)
http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/d2d410b927d2

Comment 4

[Ed Morley [:emorley]]

In production :-)

Comment 5

[Ed Morley [:emorley]]

Bah, regex fail:
https://tbpl.mozilla.org/php/getParsedLog.php?id=15457865&tree=Firefox

Comment 6

[Ed Morley [:emorley]]

Attachment: Fixup

Tested locally and works now :-)

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/36af1913e598