790659 - JS Error ReferenceError: addon is not defined

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

When I run `cfx test` I see the following error:

[JavaScript Error: "ReferenceError: addon is not defined" {file: "resource://6253b599-1c6d-495f-b637-99479a49ec5d-at-jetpack/api-utils/data/test-trusted-document.html" line: 13}]

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

P1 to see if this is just part of the test, or if it's a problem in a test.

Comment 2

[Matteo Ferretti [:zer0] [:matteo]]

The error is given by the `test-content-symbiont`, when we're test if the `addon` object is present when a content script is given:

https://github.com/mozilla/addon-sdk/blob/master/test/test-content-symbiont.js#L164-L170

Because the page loaded even in this test try to use `addon` object in any case:

https://github.com/mozilla/addon-sdk/blob/master/data/test-trusted-document.html#L12-L16

The exception is raised. I added a check on `test-trusted-document` to execute those line only if `addon` object is in `window`; that doesn't impact the result of the test because this is exactly what we're going to test anyway (that the `addon` object is not on `window`).

Comment 3

[Matteo Ferretti [:zer0] [:matteo]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/783

Pointer to Github pull-request

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/f1af9a1b92be0f48917f6ee9c5eb59bd3b9f7ddf
Bug 790659 - JS Error ReferenceError: addon is not defined

- Added check on `test-trusted-document.html` before using `addon` object

https://github.com/mozilla/addon-sdk/commit/5b321785a626fd9215d81292fce91766a2942a2b
Merge pull request #783 from ZER0/addon/790659

Fix Bug 790659 - JS Error ReferenceError: addon is not defined r=@erikvold