790677 - Update xpcshell test packaging to work for B2G

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, defect, P1)

Description

[Jonathan Griffin (:jgriffin)]

We need to update the files that get included for xpcshell in make package-tests, so we can run them for B2G.

At the same time, I'll fix the broken paths that were introduced when devicemanager was moved from build/mobile to testing/mozbase/mozdevice.

Comment 1

[Jonathan Griffin (:jgriffin)]

Turns out 'make package-tests' is totally broken on B2G; it tries to copy some Android apk's that don't exist.  I'll file a separate bug for this, and wait on this bug until that's fixed.

Comment 2

[Marshall Culpepper [:marshall_law]]

Just a bump, does the 'make package-tests' bug still need to be filed, or can that be covered by this one?

Comment 3

[Marshall Culpepper [:marshall_law]]

Noming since this blocks getting the existing updater xpcshell tests running for B2G

Comment 4

[Jonathan Griffin (:jgriffin)]

(In reply to Marshall Culpepper [:marshall_law] from comment #2)
> Just a bump, does the 'make package-tests' bug still need to be filed, or
> can that be covered by this one?

That can be covered by this.

Comment 5

[Jonathan Griffin (:jgriffin)]

Attachment: Fix xpcshell test packaging for B2G,

This adds all the necessary files to the xpcshell directory of a tests.zip package to run the tests for B2G, and fixes paths for files that used to live in build/mobile to their new location in testing/mozbase/mozdevice.  This is needed to get xpcshell tests running in CI for B2G; running them locally is covered by the patch in bug 797162.  Note that before we can run these in CI from a tests.zip package, bug 797153 will also have to be fixed.

Comment 6

[Jonathan Griffin (:jgriffin)]

With this patch:

ls objdir-gecko/dist/test-package-stage/xpcshell:

automationutils.py   head.js            moz-spdy                runxpcshelltests.py
devicemanagerADB.py  manifestparser.py  node-spdy               test
devicemanager.py     mozinfo.json       remotexpcshelltests.py  tests
devicemanagerSUT.py  mozinfo.py         runtestsb2g.py

Comment 7

[Jonathan Griffin (:jgriffin)]

pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=8f915ff65d05

Comment 8

[Mozilla RelEng Bot]

Try run for 8f915ff65d05 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=8f915ff65d05
Results (out of 16 total builds):
    success: 15
    failure: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-8f915ff65d05

Comment 9

[Jonathan Griffin (:jgriffin)]

The single try failure was a timeout:

DEBUG: doshell: chrootPath:/builds/mock_mozilla/mozilla-centos6-x86_64/root/, uid:500, gid:494
DEBUG: doshell environment: {'LANG': 'en_US.UTF-8', 'TERM': 'vt100', 'SHELL': '/bin/bash', 'TZ': 'EST5EDT', 'HOSTNAME': 'mock', 'HOME': '/builds', 'PATH': '/usr/bin:/bin:/usr/sbin:/sbin', 'TMPDIR': '/tmp'}
DEBUG: doshell: command: /usr/bin/env HG_SHARE_BASE_DIR="/builds/hg-shared" LC_ALL="C" CCACHE_COMPRESS="1" MOZ_SYMBOLS_EXTRA_BUILDID="linux64" SYMBOL_SERVER_HOST="symbols1.dmz.phx1.mozilla.com" CCACHE_DIR="/builds/ccache" POST_SYMBOL_UPLOAD_CMD="/usr/local/bin/post-symbol-upload.py" MOZ_SIGN_CMD="python /builds/slave/try-lnx64/tools/release/signing/signtool.py --cachedir /builds/slave/try-lnx64/signing_cache -t /builds/slave/try-lnx64/token -n /builds/slave/try-lnx64/nonce -c /builds/slave/try-lnx64/tools/release/signing/host.cert -H signing3.srv.releng.scl3.mozilla.com:9110" SYMBOL_SERVER_SSH_KEY="/home/mock_mozilla/.ssh/ffxbld_dsa" DISPLAY=":2" PATH="/tools/buildbot/bin:/usr/local/bin:/usr/lib64/ccache:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin:/tools/git/bin:/tools/python27/bin:/tools/python27-mercurial/bin:/home/cltbld/bin" CCACHE_BASEDIR="/builds/slave/try-lnx64" TINDERBOX_OUTPUT="1" SYMBOL_SERVER_PATH="/mnt/netapp/breakpad/symbols_ffx/" MOZ_OBJDIR="obj-firefox" MOZ_CRASHREPORTER_NO_REPORT="1" SYMBOL_SERVER_USER="ffxbld" LD_LIBRARY_PATH="/tools/gcc-4.3.3/installed/lib64" CCACHE_UMASK="002" tools/codesighs/autosummary.unix.bash -o obj-firefox -s . ../codesize-auto.log ../codesize-auto-old.log ../codesize-auto-diff.log
DEBUG: child environment: {'LANG': 'en_US.UTF-8', 'TERM': 'vt100', 'SHELL': '/bin/bash', 'TZ': 'EST5EDT', 'HOSTNAME': 'mock', 'HOME': '/builds', 'PATH': '/usr/bin:/bin:/usr/sbin:/sbin', 'TMPDIR': '/tmp'}

command timed out: 1200 seconds without output, attempting to kill

I assume this has nothing to do with this patch, as I've seen the same error on other try runs today.

Comment 10

[Alex Keybl [:akeybl]]

Blocks a P1/blocker. Marking this as a P1/blocker.

Comment 11

[Jonathan Griffin (:jgriffin)]

review ping

Comment 12

[(not currently active) Ted Mielczarek]

Comment on attachment 668244 [details] [diff] [review]
Fix xpcshell test packaging for B2G,

Review of attachment 668244 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay.

Comment 13

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0f76c881a47b

Comment 14

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/0f76c881a47b

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/23c0fc8a264c