790807 - Add nsA[C]String::ToInteger64

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Steve Workman [:sworkman] (INACTIVE)]

Attachment: v1 nsA[C]String::ToInteger64

DASH (Dynamic Adaptive Streaming over HTTP - bug 734546) requires string to 64-bit integer conversion for processing HTTP byte range responses for files of size >2GB.

Some background on DASH for Firefox:
We're implementing the WebM On Demand profile, which means non-muxed (separate audio and file streams), non-chunked (single files per stream) media. We download the media files in chunks corresponding to HTTP byte range requests. This is to allow for adaptive stream switching between chunks, i.e. switching between streams which are encoded at different bitrates in response to changes in network bandwidth.
Since video files can easily be >2GB, and DASH-WebM On Demand is based on byte range requests for single files, DASH in Gecko needs to be able to parse HTTP responses into 64 bit integers in order to address byte ranges >2GB.

Comment 1

[Steve Workman [:sworkman] (INACTIVE)]

First patch uploaded at bug creation:
-- Adds nsA[C]String::ToInteger64. Code from existing ToInteger implementation was simply copied and adjusted to deal with 64 bit integers. In order to avoid regressions of what is surely a heavily used function, no code is directly shared, just copied.

Let me know if avoiding regressions in this way is what you want to do, or if there's another approach you want to take.

Comment 2

[Steve Workman [:sworkman] (INACTIVE)]

Comment on attachment 660612 [details] [diff] [review]
v1 nsA[C]String::ToInteger64

https://hg.mozilla.org/integration/mozilla-inbound/rev/607ed3a68688

Comment 3

[Steve Workman [:sworkman] (INACTIVE)]

Thanks for the r+!

Comment 4

[Graeme McCutcheon [:graememcc]]

https://hg.mozilla.org/mozilla-central/rev/607ed3a68688