790815 - appStatus is not properly set for packaged apps

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[David Chan [:dchan]]

Attachment: add appStatus to app object

packages apps will always be assigned a status of Ci.nsIPrincipal.APP_STATUS_INSTALLED;

This is due to appStatus being added to the wrong object

From installPackage in Webapps.jsm [1]

615           if (!checkAppStatus(msg.app.manifest)) {
616             throw "INVALID_SECURITY_LEVEL";
617           }
618 
619           msg.appStatus = getAppStatus(msg.app.manifest);
620           Services.obs.notifyObservers(this, "webapps-ask-install",
621                                              JSON.stringify(msg));

L619 adds appStatus to the msg object.
This is passed to doInstall in webappsUI.jsm [2]
which returns to confirmInstall in webapps.jsm


337     let app = aData.app;
...
358 
359     let appObject = AppsUtils.cloneAppObject(app);
360     appObject.appStatus = app.appStatus || Ci.nsIPrincipal.APP_STATUS_INSTALLED;
361     appObject.installTime = app.installTime = Date.now();

confirmInstall retrieves app from "msg"
then accesses app.appStatus which is undefined L360
appStatus is defined at aData.appStatus

patch attached changes L619 to assign to msg.app.appStatus. Alternative is to pull the status from aData.appStatus


[1] - http://mxr.mozilla.org/mozilla-central/source/dom/apps/src/Webapps.jsm#619
[2] - http://mxr.mozilla.org/mozilla-central/source/browser/modules/webappsUI.jsm#106

Comment 1

[[:fabrice] Fabrice Desré]

Comment on attachment 660623 [details] [diff] [review]
add appStatus to app object

David, can you set the Author field and commit message on your patch?

Comment 2

[David Chan [:dchan]]

Attachment: add appStatus to app object v2

Moving over review from previous patch.

Fabrice: I'm assuming this is the output you want?

Comment 3

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f5a65da34f1d

Comment 4

[[:fabrice] Fabrice Desré]

backed out and repushed with the corrent commit message:
https://hg.mozilla.org/integration/mozilla-inbound/rev/733502ee9d08
https://hg.mozilla.org/integration/mozilla-inbound/rev/462d7c9e496b

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/462d7c9e496b

Comment 6

[Andrew Overholt [:overholt]]

Definitely a requirement.