790817 - Make installing xpcshell tests onto B2G devices faster

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, defect)

Description

[Jonathan Griffin (:jgriffin)]

Currently, we install xpcshell tests onto the device in the same manner as for Fennec, namely, one file at a time.  This takes, +/- 5 minutes, forever.

A better method would be to tar all the files up, move the one single tar file to the device, and then untar them on the other side, ala https://github.com/mozilla-b2g/gaia/blob/master/build/install-gaia.py#L123

I imagine this would be about a bazillion times faster.

Comment 1

[Geoff Brown [:gbrown]]

There is code in devicemanagerADB that will zip/push/unzip a whole directory, if all the tools are available: http://mxr.mozilla.org/mozilla-central/source/testing/mozbase/mozdevice/mozdevice/devicemanagerADB.py#208

Setup for xpcshell-tests-remote is dramatically faster when this is used.

Comment 2

[Mihnea Dobrescu-Balaur (:mihneadb)]

What :gbrown said wfm on otoro after I install busybox via this script [1].

Also a thing that takes a while is the "cleanup" that occurs before running tests [2].


[1] https://github.com/mihneadb/Negatus/blob/master/setup-tools.sh
[2] https://mxr.mozilla.org/mozilla-central/source/testing/xpcshell/runtestsb2g.py#26

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

For me on a Nexus S phone this takes much more than 5 minutes --- at least 30 minutes, I don't know for sure as I haven't been able to complete that process.

devicemanagerADB.py seems to have the ability to zip directories, push them, and unzip on the device.

devicemanagerSUT.py does not seem to have this ability.

Comment 4

[Mihnea Dobrescu-Balaur (:mihneadb)]

:bjacob, did you install busybox?

Comment 5

[Benoit Jacob [:bjacob] (mostly away)]

That device wasn't rooted.
On a rooted device with busybox, devicemanagerADB does work fast. But devicemanagerSUT is still slow.

Comment 6

[Jonathan Griffin (:jgriffin)]

We'd like to figure out the best way to install busybox on the emulator inside buildbot for running xpcshell tests on TBPL.

Ted, do you think we can check the busybox binary into the tree?  I see gaia already has done this:  https://github.com/mozilla-b2g/gaia/tree/master/build

Alternatively, we could upload busybox to tooltool and add a mozharness step to download it and install in the emulator.

Checking it into the tree would have the advantage that the automation could install it automatically for developers running tests locally.

Comment 7

[Andrew Halberstadt [:ahal]]

Attachment: Patch 1.0 - add ability to install busybox to emulator.py

I made this patch because testing locally was becoming too annoying. This sets up the automation to accept a --busybox option which will get emulator.py to install it for you. This way when we figure out how to get busybox in automation all we'll need to do is add the --busybox parameter to the mozharness configs

Comment 8

[Jonathan Griffin (:jgriffin)]

Comment on attachment 686198 [details] [diff] [review]
Patch 1.0 - add ability to install busybox to emulator.py

Review of attachment 686198 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!  We can file a separate bug to upload the busybox binary to tooltool so we can use it in mozharness scripts in TBPL.

All this retry code makes me think we might eventually want to add a 'retry' parameter to devicemanager's standard pushFile and pushDir methods.

Comment 9

[Andrew Halberstadt [:ahal]]

I filed bug 816216 to add a retry parameter to various devicemanager commands.

Comment 10

[Andrew Halberstadt [:ahal]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/976c19959c05

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/976c19959c05

Comment 12

[Andrew Halberstadt [:ahal]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d85cbf41e9b6

Comment 13

[Andrew Halberstadt [:ahal]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7ea9f92a4ac6