make package-tests broken on B2G

RESOLVED FIXED in mozilla18

Status

RESOLVED FIXED
6 years ago
8 months ago

People

(Reporter: jgriffin, Assigned: jgriffin)

Tracking

Trunk
mozilla18
All
Gonk (Firefox OS)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
make package-tests fails on B2G because it tries to package some nonexistent Android files:

make package-tests
rm -rf ./dist/test-package-stage
/home/jgriffin/armB2G/objdir-gecko/config/nsinstall -D ./dist/test-package-stage
/home/jgriffin/armB2G/objdir-gecko/config/nsinstall -D ./dist/test-package-stage/bin
/home/jgriffin/armB2G/objdir-gecko/config/nsinstall -D ./dist/test-package-stage/bin/components
/home/jgriffin/armB2G/objdir-gecko/config/nsinstall -D ./dist/test-package-stage/certs
/home/jgriffin/armB2G/objdir-gecko/config/nsinstall -D ./dist/test-package-stage/jetpack
/home/jgriffin/armB2G/objdir-gecko/config/nsinstall -D ./dist/test-package-stage/firebug
/home/jgriffin/armB2G/objdir-gecko/config/nsinstall -D ./dist/test-package-stage/peptest
/home/jgriffin/armB2G/objdir-gecko/config/nsinstall -D ./dist/test-package-stage/mozbase
/home/jgriffin/armB2G/objdir-gecko/config/nsinstall -D ./dist/test-package-stage/modules
/home/jgriffin/armB2G/objdir-gecko/config/nsinstall ./build/mobile/sutagent/android/sutAgentAndroid.apk ./dist/test-package-stage/bin
/home/jgriffin/armB2G/objdir-gecko/config/nsinstall: cannot access ./build/mobile/sutagent/android/sutAgentAndroid.apk: No such file or directory
make: *** [stage-android] Error 1
(Assignee)

Comment 1

6 years ago
Created attachment 660642 [details] [diff] [review]
Don't package Android apk's for B2G
(Assignee)

Comment 2

6 years ago
pushed to try to make sure I didn't break Android packaging: https://tbpl.mozilla.org/?tree=Try&rev=8eb07d070701
Comment on attachment 660642 [details] [diff] [review]
Don't package Android apk's for B2G

You should be able to use MOZ_WIDGET_TOOLKIT here. Please don't condition things on MOZ_BUILD_APP, that way lies madness.
(Assignee)

Comment 4

6 years ago
Created attachment 660979 [details] [diff] [review]
Don't package Android apk's for B2G

Changed to MOZ_WIDGET_TOOLKIT and pushed to try
(Assignee)

Updated

6 years ago
Attachment #660642 - Attachment is obsolete: true

Comment 5

6 years ago
Try run for c51d45844b52 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=c51d45844b52
Results (out of 14 total builds):
    success: 14
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/jgriffin@mozilla.com-c51d45844b52
(Assignee)

Comment 6

6 years ago
Comment on attachment 660979 [details] [diff] [review]
Don't package Android apk's for B2G

The try run came back ok for both android and non-android packages.
Attachment #660979 - Flags: review?(ted.mielczarek)
Attachment #660979 - Flags: review?(ted.mielczarek) → review+
https://hg.mozilla.org/mozilla-central/rev/e83d9f2e0699
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

8 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.