790827 - make package-tests broken on B2G

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Jonathan Griffin (:jgriffin)]

make package-tests fails on B2G because it tries to package some nonexistent Android files:

make package-tests
rm -rf ./dist/test-package-stage
/home/jgriffin/armB2G/objdir-gecko/config/nsinstall -D ./dist/test-package-stage
/home/jgriffin/armB2G/objdir-gecko/config/nsinstall -D ./dist/test-package-stage/bin
/home/jgriffin/armB2G/objdir-gecko/config/nsinstall -D ./dist/test-package-stage/bin/components
/home/jgriffin/armB2G/objdir-gecko/config/nsinstall -D ./dist/test-package-stage/certs
/home/jgriffin/armB2G/objdir-gecko/config/nsinstall -D ./dist/test-package-stage/jetpack
/home/jgriffin/armB2G/objdir-gecko/config/nsinstall -D ./dist/test-package-stage/firebug
/home/jgriffin/armB2G/objdir-gecko/config/nsinstall -D ./dist/test-package-stage/peptest
/home/jgriffin/armB2G/objdir-gecko/config/nsinstall -D ./dist/test-package-stage/mozbase
/home/jgriffin/armB2G/objdir-gecko/config/nsinstall -D ./dist/test-package-stage/modules
/home/jgriffin/armB2G/objdir-gecko/config/nsinstall ./build/mobile/sutagent/android/sutAgentAndroid.apk ./dist/test-package-stage/bin
/home/jgriffin/armB2G/objdir-gecko/config/nsinstall: cannot access ./build/mobile/sutagent/android/sutAgentAndroid.apk: No such file or directory
make: *** [stage-android] Error 1

Comment 1

[Jonathan Griffin (:jgriffin)]

Attachment: Don't package Android apk's for B2G

Comment 2

[Jonathan Griffin (:jgriffin)]

pushed to try to make sure I didn't break Android packaging: https://tbpl.mozilla.org/?tree=Try&rev=8eb07d070701

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 660642 [details] [diff] [review]
Don't package Android apk's for B2G

You should be able to use MOZ_WIDGET_TOOLKIT here. Please don't condition things on MOZ_BUILD_APP, that way lies madness.

Comment 4

[Jonathan Griffin (:jgriffin)]

Attachment: Don't package Android apk's for B2G

Changed to MOZ_WIDGET_TOOLKIT and pushed to try

Comment 5

[Mozilla RelEng Bot]

Try run for c51d45844b52 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=c51d45844b52
Results (out of 14 total builds):
    success: 14
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-c51d45844b52

Comment 6

[Jonathan Griffin (:jgriffin)]

Comment on attachment 660979 [details] [diff] [review]
Don't package Android apk's for B2G

The try run came back ok for both android and non-android packages.

Comment 7

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e83d9f2e0699

Comment 8

[Graeme McCutcheon [:graememcc]]

https://hg.mozilla.org/mozilla-central/rev/e83d9f2e0699