790829 - Use updated version of cef library

Status: RESOLVED FIXED

(Cloud Services :: Server: Core, defect)

Description

[Ryan Kelly [:rfkelly]]

The "cef" python library has been updated due to a bug in its message formatting (it was using the field name "dest" where it should have used "dhost"):

    https://github.com/mozilla/cef/pull/1

This bug is a reminder that we should bump it in our deps files and deploy it during the next round of updates.

Comment 1

[Ryan Kelly [:rfkelly]]

Attachment: patch to update cef dependency version

As seen in the link from the previous comment, the latest version of python "cef" library fixes a data-formatting bug.  It was using fieldname "dest" when it should have been using "dhost".

Is it safe to push this out to sync production machines, or might that break some of our monitoring infrastructure that expects messaging using the old format?

Comment 2

[Toby Elliott [:telliott]]

Comment on attachment 673067 [details] [diff] [review]
patch to update cef dependency version

How long has this error been in production? While we should obviously fix it, if it's been kicking around wrongly for a year or something, it would suggest that we don't use the field and the change can wait until the next release.

Comment 3

[Ryan Kelly [:rfkelly]]

(In reply to Toby Elliott [:telliott] from comment #2)
> Comment on attachment 673067 [details] [diff] [review]
> patch to update cef dependency version
> 
> How long has this error been in production?

Since the initial switch-over to python I guess.

> While we should obviously fix
> it, if it's been kicking around wrongly for a year or something, it would
> suggest that we don't use the field and the change can wait until the next
> release.

Yep, I don't think we need to rush out a fix or anything - just want to be sure it's safe to include when we get around to it.

Comment 4

[David Chan [:dchan]]

Comment on attachment 673067 [details] [diff] [review]
patch to update cef dependency version

Sorry missed this in my queue. The diff between 0.4 and 0.5 looked good to me

Comment 5

[Toby Elliott [:telliott]]

server-storage still has a prod-req of 0.4. Please update that and then I think we're good to close this out.

Comment 6

[Ryan Kelly [:rfkelly]]

Committed across the board:

http://hg.mozilla.org/services/server-storage/rev/d32f0be2fff3
http://hg.mozilla.org/services/server-reg/rev/da80c31c2038
http://hg.mozilla.org/services/server-sreg/rev/cb2615c1e4a9
http://hg.mozilla.org/services/server-key-exchange/rev/f5ac4c0bcf03
http://hg.mozilla.org/services/server-node-assignment/rev/b947628f949f