Use updated version of cef library

RESOLVED FIXED

Status

Cloud Services
Server: Core
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: rfkelly, Assigned: rfkelly)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa+])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
The "cef" python library has been updated due to a bug in its message formatting (it was using the field name "dest" where it should have used "dhost"):

    https://github.com/mozilla/cef/pull/1

This bug is a reminder that we should bump it in our deps files and deploy it during the next round of updates.
(Assignee)

Comment 1

6 years ago
Created attachment 673067 [details] [diff] [review]
patch to update cef dependency version

As seen in the link from the previous comment, the latest version of python "cef" library fixes a data-formatting bug.  It was using fieldname "dest" when it should have been using "dhost".

Is it safe to push this out to sync production machines, or might that break some of our monitoring infrastructure that expects messaging using the old format?
Attachment #673067 - Flags: review?(telliott)
Attachment #673067 - Flags: feedback?(dchan+bugzilla)
Comment on attachment 673067 [details] [diff] [review]
patch to update cef dependency version

How long has this error been in production? While we should obviously fix it, if it's been kicking around wrongly for a year or something, it would suggest that we don't use the field and the change can wait until the next release.
Attachment #673067 - Flags: review?(telliott) → review+
(Assignee)

Comment 3

6 years ago
(In reply to Toby Elliott [:telliott] from comment #2)
> Comment on attachment 673067 [details] [diff] [review]
> patch to update cef dependency version
> 
> How long has this error been in production?

Since the initial switch-over to python I guess.

> While we should obviously fix
> it, if it's been kicking around wrongly for a year or something, it would
> suggest that we don't use the field and the change can wait until the next
> release.

Yep, I don't think we need to rush out a fix or anything - just want to be sure it's safe to include when we get around to it.

Comment 4

6 years ago
Comment on attachment 673067 [details] [diff] [review]
patch to update cef dependency version

Sorry missed this in my queue. The diff between 0.4 and 0.5 looked good to me
Attachment #673067 - Flags: feedback?(dchan+bugzilla) → feedback+
server-storage still has a prod-req of 0.4. Please update that and then I think we're good to close this out.
Whiteboard: [qa+]
You need to log in before you can comment on or make changes to this bug.