790853 - Bol search engine leads to 404 in Firefox Beta for Android

Status: RESOLVED FIXED

(Mozilla Localizations :: nl / Dutch, defect)

Description

[Aaron Train [:aaronmt]]

http://mxr.mozilla.org/l10n-mozilla-beta/source/nl/mobile/searchplugins/bolcom-nl.xml

STR:

i) Install Firefox Beta for Android
ii) Tap the awesome-bar, input a search and tap the Bol search engine

Search leads to a 404 on bol.com

Comment 1

[Ton [:Tonnes]]

Looks like bol.com changed its search url a while ago, as this also affects FX 15 for desktop as well as for Android. Tim, could you fix it?

Comment 2

[Tim Maks van den Broek [:mad_maks]]

sure, i have to find out is the right string right now. 

Pike what is the policy for changing searchplugins at this moment?

Comment 3

[Tim Maks van den Broek [:mad_maks]]

http://www.bol.com/nl/s/algemeen/zoekresultaten/Ntt/{searchTerms}/Ntk/media_all/Nty/1/suggestedFor/{searchTerms}/N/0/Ne/0/search/true/searchType/qck/index.html

is the right search string

Comment 4

[Axel Hecht [:Pike]]

Please create a patch, attach it here and request review from Milos.

Comment 5

[Tim Maks van den Broek [:mad_maks]]

(In reply to Axel Hecht [:Pike] from comment #4)
> Please create a patch, attach it here and request review from Milos.

thanks, can i do that for all the dutch products with bol.com in one patch?

Comment 6

[Axel Hecht [:Pike]]

Weird url. SearchForm seems to be http://www.bol.com/nl/catalogus/uitgebreid_zoeken.html, and I get along with just http://www.bol.com/nl/s/algemeen/zoekresultaten/Ntt/{searchTerms}/N/0/search/true/searchType/qck/sc/media_all/index.html for search.

Comment 7

[Axel Hecht [:Pike]]

(In reply to Tim Maks van den Broek from comment #5)
> (In reply to Axel Hecht [:Pike] from comment #4)
> > Please create a patch, attach it here and request review from Milos.
> 
> thanks, can i do that for all the dutch products with bol.com in one patch?

Yeah.

Comment 8

[Tim Maks van den Broek [:mad_maks]]

(In reply to Axel Hecht [:Pike] from comment #6)
> Weird url. SearchForm seems to be
> http://www.bol.com/nl/catalogus/uitgebreid_zoeken.html, and I get along with
> just
> http://www.bol.com/nl/s/algemeen/zoekresultaten/Ntt/{searchTerms}/N/0/search/
> true/searchType/qck/sc/media_all/index.html for search.

you are right (i did a quick search and found the string in a mycroft searchplugin.) when i update the plugin at home i would tested it more :-)

the patch will come in a few days when i am at home.

Comment 9

[Ton [:Tonnes]]

Any news on this?

Comment 10

[Tim Maks van den Broek [:mad_maks]]

Attachment: bolcom-nl.xml patch

fix for bol.com search

Comment 11

[Tim Maks van den Broek [:mad_maks]]

ping

Comment 12

[Milos Dinic [:Milos]]

Comment on attachment 666659 [details] [diff] [review]
bolcom-nl.xml patch

Review of attachment 666659 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r+. Please land this to all concerning repositories mentioning this bug and summary in the commit message, along with my review.

Thanks!

Comment 13

[Tim Maks van den Broek [:mad_maks]]

Comment on attachment 666659 [details] [diff] [review]
bolcom-nl.xml patch

committed:

http://hg.mozilla.org/releases/l10n/mozilla-beta/nl/rev/48f71e5a401f
http://hg.mozilla.org/releases/l10n/mozilla-aurora/nl/rev/9fd6f63f2395

Comment 14

[Cristian Nicolae (:xti)]

This issue is fixed on the latest Beta and Aurora builds, but it's still reproducible on the latest Nightly.

--
Firefox for Android 17.0b3 (2012-10-23)
Firefox for Android 18.0a2 (2012-10-23)

Device: Galaxy S2
OS: Android 4.0.3

Comment 15

[Tim Maks van den Broek [:mad_maks]]

(In reply to Cristian Nicolae (:xti) from comment #14)
> This issue is fixed on the latest Beta and Aurora builds, but it's still
> reproducible on the latest Nightly.
> 
nighly will be fixed when I merged aurora and central at the next merge date.

Comment 16

[Tim Maks van den Broek [:mad_maks]]

I merged aurora into central today so this will be also fixed in the next nightly build