Editing dependencies from the "Change Several Bugs at Once" page does not work as expected (bug IDs are incorrectly parsed)

RESOLVED FIXED in Bugzilla 4.0

Status

()

Bugzilla
Creating/Changing Bugs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Klaus Bittrich, Assigned: Frédéric Buclin)

Tracking

({regression})

4.2.3
Bugzilla 4.0
regression
Bug Flags:
approval +
approval4.4 +
blocking4.4 +
approval4.2 +
blocking4.2.4 +
approval4.0 +
blocking4.0.9 +

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.1 (KHTML, like Gecko) Chrome/21.0.1180.79 Safari/537.1

Steps to reproduce:

On a list of bugs choose "Change Several Bugs at Once". Check some bugs to change and enter some valid bug ids in the format 1,2,3 or 1 2 3 in either "Depends On" or "Blocks".


Actual results:

Bugzilla presented an error-page with the error: '1,2,3' is not a valid bug number.


Expected results:

The entered bug ids should have been split in the same way they are split when you edit a single bug.

Currently in process_bug.cgi the depends/blocked ids are split by /\s,/ - so a possible solution could be to split by /[\s,]+/ like every where else.
(Assignee)

Comment 1

5 years ago
This is a regression due to bug 556167, which affects 4.0 are newer. Bugzilla 4.0 is restricted to security fixes only, but this is a regression and it's almost impossible to edit dependencies correctly anymore from this page. Also, the fix is trivial and safe.
Status: UNCONFIRMED → NEW
Depends on: 556167
Ever confirmed: true
Flags: blocking4.4+
Flags: blocking4.2.4+
Flags: blocking4.0.9+
Keywords: regression
Summary: Splitting of multiple bug ids on "Change Several Bugs at Once" does not work as expected → Editing dependencies from the "Change Several Bugs at Once" page does not work as expected (bug IDs are incorrectly parsed)
Target Milestone: --- → Bugzilla 4.0
(Assignee)

Comment 2

5 years ago
Created attachment 660850 [details] [diff] [review]
patch, v1
Assignee: create-and-change → LpSolit
Status: NEW → ASSIGNED
Attachment #660850 - Flags: review?(dkl)
Comment on attachment 660850 [details] [diff] [review]
patch, v1

Review of attachment 660850 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. r=dkl
Attachment #660850 - Flags: review?(dkl) → review+
(Assignee)

Updated

5 years ago
Flags: approval4.4+
Flags: approval4.2+
Flags: approval4.0+
Flags: approval+
(Assignee)

Comment 4

5 years ago
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified process_bug.cgi
Committed revision 8412.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.4/
modified process_bug.cgi
Committed revision 8407.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.2/
modified process_bug.cgi
Committed revision 8145.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.0/
modified process_bug.cgi
Committed revision 7726.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.