Closed
Bug 790911
Opened 12 years ago
Closed 12 years ago
[New Tab Page] link checker unnecessarily reports spams the error console
Categories
(Firefox :: Tabbed Browser, defect)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
Firefox 18
People
(Reporter: ttaubert, Assigned: ttaubert)
References
Details
Attachments
(2 files)
|
6.35 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
|
848 bytes,
patch
|
jaws
:
review+
|
Details | Diff | Splinter Review |
The link checker introduced by bug 765628 spams the error console in case the new tab page contains a site we're not displaying for security reasons. That's because nsIScriptSecurityManager.checkLoadURIWithPrincipal() always reports errors to the console which doesn't really make sense for the background check the new tab page does.
|
Assignee | |
Comment 1•12 years ago
|
||
|
|
Assignee | |
Comment 2•12 years ago
|
||
Attachment #660791 -
Flags: review?(jaws)
|
|
Assignee | |
Updated•12 years ago
|
Attachment #660790 -
Flags: review?(bzbarsky)
|
||
Comment 3•12 years ago
|
||
Comment on attachment 660790 [details] [diff] [review]
part 1 - add a flag to suppress error reporting when using checkLoadURIWithPrincipal()
r=me
Attachment #660790 -
Flags: review?(bzbarsky) → review+
|
||
Updated•12 years ago
|
Attachment #660791 -
Flags: review?(jaws) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/c7b6aa285dd4
https://hg.mozilla.org/integration/fx-team/rev/b03eca299005
Whiteboard: [fixed-in-fx-team]
|
|
Assignee | |
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b03eca299005
https://hg.mozilla.org/mozilla-central/rev/c7b6aa285dd4
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 18
You need to log in
before you can comment on or make changes to this bug.
Description
•