Closed Bug 790938 Opened 7 years ago Closed 7 years ago

add a test for SVG-in-OpenType glyphs in an SVG mask

Categories

(Core :: SVG, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: heycam, Assigned: heycam)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
This works, so we should have a test for it.
Attachment #660818 - Flags: review?(eflores)
Actually, there is a problem (when running without my bug 655877 patches).  It seems the stroke on the first rect in the reference file isn't rendered in the mask?
Comment on attachment 660818 [details] [diff] [review]
patch

Review of attachment 660818 [details] [diff] [review]:
-----------------------------------------------------------------

Test is good; my code evidently isn't. From http://www.w3.org/TR/SVG/masking.html#Masking:

"The alpha mask that is used to composite the current object into the background represents the product of the luminance of the color channels and the alpha channel from the mask."
Attachment #660818 - Flags: review?(eflores) → review+
Right, of course.  (Amazing how <mask>'s use of luminance still trips me up.)
https://hg.mozilla.org/mozilla-central/rev/013a65100228
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.