790947 - Show in the error console the path to the dumped memory reports

Status: RESOLVED FIXED

(Toolkit :: about:memory, defect)

Description

[Florian Quèze [:florian]]

Attachment: Patch

Bug 768470 added a way to dump the memory reports to a file, but the path where they are dumped isn't obvious (to me at least).

On Mac they are in ~/Library/Caches/TemporaryItems/memory-reports-<pid>.json
I didn't know that folder existed, and looked only in /tmp and /var/tmp.

The attached patch dumps the path to the Error Console, exactly like the cycle collector dump does (http://hg.mozilla.org/mozilla-central/annotate/f39786e8364d/xpcom/base/nsCycleCollector.cpp#l1345).

Comment 1

[Nicholas Nethercote [inactive]]

Comment on attachment 660826 [details] [diff] [review]
Patch

Review of attachment 660826 [details] [diff] [review]:
-----------------------------------------------------------------

Great idea, thanks for the patch.

::: xpcom/base/nsMemoryReporterManager.cpp
@@ +1028,5 @@
> +    if (cs) {
> +      nsString path;
> +      if (NS_SUCCEEDED(tmpFile->GetPath(path)))
> +        cs->LogStringMessage(path.get());
> +    }

Just printing the filename by itself looks a bit odd.  Can you change it to something like "nsIMemoryReporterManager::dumpReports() dumped reports to <file>"?

(I realize the CC dump just prints the filename;  bonus points if you change that message similarly.)

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

when you create CC/GC logs, you get the full path in error console.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Er, I totally misinterpreted "I realize the CC dump just prints the filename" :)

Feel free to change CC/GC error console messages too.

Comment 4

[Florian Quèze [:florian]]

Attachment: Patch v2

Comment 5

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/045c549ff078

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/045c549ff078