Closed
Bug 79095
Opened 24 years ago
Closed 24 years ago
Crash opening any helper app
Categories
(Core :: DOM: Navigation, defect)
Tracking
()
People
(Reporter: bzbarsky, Assigned: jud)
Details
(Keywords: crash, platform-parity, regression)
Attachments
(1 file)
3.17 KB,
text/plain
|
Details |
BUILD: 2001-05-05-05 on Linux and 2001-05-06 CVS build STEPS TO REPRODUCE: 1) Set up a helper for any mimetype. (I've tried PDF and postscript, with acroread and gv as viewers). 2) Try to open a URL for that mimetype 3) watch the crash ###!!! ASSERTION: You can't dereference a NULL nsCOMPtr with operator->().: 'mRawPtr != 0', file ../../../dist/include/nsCOMPtr.h, line 649 ###!!! Break: at file ../../../dist/include/nsCOMPtr.h, line 649
Reporter | ||
Comment 1•24 years ago
|
||
This did not crash in 2001-05-02-05 (though it also did not launch the helper). ccing law and morse (morse based on the stack trace): #0 0x421b7d96 in nsWalletlibService::OnStateChange (this=0x426fcc08, aWebProgress=0x43a21014, aRequest=0x43879890, progressStateFlags=131088, aStatus=0) at nsWalletService.cpp:260 #1 0x40fdeb6f in nsDocLoaderImpl::FireOnStateChange (this=0x81bd348, aProgress=0x43a21014, aRequest=0x43879890, aStateFlags=131088, aStatus=0) at nsDocLoader.cpp:1089 #2 0x40fdebf9 in nsDocLoaderImpl::FireOnStateChange (this=0x43a21000, aProgress=0x43a21014, aRequest=0x43879890, aStateFlags=131088, aStatus=0) at nsDocLoader.cpp:1096 (gdb) frame 0 #0 0x421b7d96 in nsWalletlibService::OnStateChange (this=0x426fcc08, aWebProgress=0x43a21014, aRequest=0x43879890, progressStateFlags=131088, aStatus=0) at nsWalletService.cpp:260 260 rv = domWin->GetDocument(getter_AddRefs(domDoc)); (gdb) p domWin $1 = {mRawPtr = 0x0}
Keywords: regression
Reporter | ||
Comment 2•24 years ago
|
||
Comment 3•24 years ago
|
||
I can't reproduce the crash on windows. But, from the stacktrace, the fix should be straightforward -- namely add the following line before line 260 in nsWalletService.cpp: if (!domWin) return NS_ERROR_FAILURE; Of course it's curious why this crash should suddenly start occuring. Nothing has changed in this module. So perhaps something has changed upstream causing the problem. It's also curious that the GetDOMWindow call above it didn't return an error message when it returned a null value of domWin. Could there be a problem in GetDOMWindow?
Comment 4•24 years ago
|
||
I confirm the crash on Linux build from newly updated (2001-05-06) cvs sources.
Reporter | ||
Comment 5•24 years ago
|
||
OK.. This works correctly in 2001-05-04-08. It crashes in 2001-05-04-21. I checked out source for 13:20 PDT on 2001-05-04 (ie right after valeski's checkin) and it's broken in that build. Since valeski touched DocLoaderImpl, chances are he broke this. Reassigning and resetting component.
Assignee: neeti → valeski
Component: Networking → Embedding: Docshell
Assignee | ||
Comment 6•24 years ago
|
||
same problem. steve, I'm not sure the null check is what we want. pavlov points out (in 79018) that we probably shouldn't be returning null from the webprogresss impl. *** This bug has been marked as a duplicate of 79018 ***
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•