Closed
Bug 791026
Opened 13 years ago
Closed 12 years ago
PageMod docs should not have examples with deprecated APIs
Categories
(Add-on SDK Graveyard :: Documentation, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: irakli, Unassigned)
Details
Attachments
(1 file)
No description provided.
|
Reporter | |
Comment 1•13 years ago
|
||
Pointer to Github pull-request
|
|
Reporter | |
Comment 2•13 years ago
|
||
Comment on attachment 660904 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/573
><!DOCTYPE html><meta charset="utf-8"><meta http-equiv="refresh" content="5;https://github.com/mozilla/addon-sdk/pull/573"><title>Bugzilla Code Review</title><p>You can review this patch at <a href="https://github.com/mozilla/addon-sdk/pull/573">https://github.com/mozilla/addon-sdk/pull/573</a>, or wait 5 seconds to be redirected there automatically.</p>
Attachment #660904 -
Flags: review?(wbamberg)
Priority: -- → P1
|
||
Comment 3•13 years ago
|
||
Comment on attachment 660904 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/573
As noted in the PR, I think this also needs to update the global onMessage call. However, it's possible that the fix for bug 787035 (update to page-mod doc) will remove those code samples completely, and make this bug fix unnecessary.
So if we wait a bit, this bug might fix itself!
Attachment #660904 -
Flags: review?(wbamberg) → review-
|
|
||
Comment 4•12 years ago
|
||
This sample was removed by the fix for bug 787035, so marking as fixed.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•