791036 - Intermittent failure to change the value of the currently selected <select> field in a mozbrowser frame

Status: VERIFIED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Jason Smith [:jsmith]]

Attachment: Logcat

Followup to bug 781438. On today's build (9/13) on device, we still intermittently fail to change the value of the currently selected <select> field in a mozbrowser frame. Error message seen in the logcat is below:

E/GeckoConsole(  105): [JavaScript Error: "NS_ERROR_NOT_INITIALIZED: Component returned failure code: 0xc1f30001 (NS_ERROR_NOT_INITIALIZED) [nsIMessageSender.sendAsyncMessage]" {file: "jar:file:///system/b2g/omni.ja!/components/MozKeyboard.js" line: 69}]

Comment 1

[Cervantes Yu [:cyu] [:cervantes]]

STR:

- Open UI test app.
- Go back to home and open another app (e.g. Dialier).
- Go back to home and open UI test app. Select is not working.

To reproduce the JavaScript Error, quit the other app and go back to the first app. The value selector will cause the above error when clicking OK.

Comment 2

[Cervantes Yu [:cyu] [:cervantes]]

Attachment: Fix MozKeyboard for value selector only working on the last opened app.

We need to handle the multiple apps that can trigger value selector.

The problem is we save the message manager on app start, so when we open 2 apps and then switch back to the first app, this._messageManager still points to the 2nd app's mm.

The patch registers separate closures with each message manager and switches this._messageManager when an app triggers the value selector.

Comment 3

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Comment on attachment 662866 [details] [diff] [review]
Fix MozKeyboard for value selector only working on the last opened app.

I found this patch might need further modification during my verification.
If the last "Forms:Input" is not triggered by a forms.js which holds the focused element, this._messageManager.sendAsyncMessage() will still send message to a forms.js that has no previousTarget.

Comment 4

[Cervantes Yu [:cyu] [:cervantes]]

This appears to be a separate issue. The value selector shouldn't allow the user to click through it to the underlying app to trigger the blur event.

Comment 5

[Cervantes Yu [:cyu] [:cervantes]]

Test on try: https://tbpl.mozilla.org/?tree=Try&rev=f4bfc137d580

No added automatic test since the STR involves multiple apps.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3b1d2d4be337

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3b1d2d4be337