791156 - OnStopRequest called multiple times on multipart/x-mixed-replace request open at shutdown (###!!! ABORT: these flags shouldn't get set until OnStopRequest. Duplicate calls to OnStopRequest?: '!mIsFullyLoaded && !mHaveAnimations' VectorImage.cpp)

Status: NEW

(Core :: Networking, defect, P3)

Description

[Joe Drew (not getting mail)]

Attachment: stack traces of multiple OnStopRequests

In tests for bug 787899 I exposed this bug, but those patches aren't required for this bug to exist, I think.

When Imagelib loads images, it uses an nsIStreamConverterService to convert from multipart/x-mixed-replace to the individual parts (when appropriate). Unfortunately, it seems that OnStopRequest is called twice in this case: once from nsMultiMixedConv::OnDataAvailable via nsMultiMixedConv::SendStop, and once on shutdown from nsStreamListenerTee::OnStopRequest.

My understanding is that OnStopRequest is meant to be called exactly once; something is breaking this invariant.

This causes problems in a followup test patch I'm going to attach (which *does* rely on the patches in bug 787899); it causes an abort in VectorImage because OnStopRequest is being called twice.

Comment 1

[Joe Drew (not getting mail)]

Attachment: expose bug

Apply this patch and run the mochitest as follows, and on shutdown you'll hit the abort/assertion in VectorImage I mentioned.

 objdir/_tests/testing/mochitest$ python runtests.py --test-path=image/test/mochitest/test_bug733553.html

Comment 2

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258

Comment 3

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258

Comment 4

[Klassic Winkler]

Attachment: same problem

Thanks from cetamadsril1980.