Work around gcc enum class compiler bug

RESOLVED FIXED in mozilla18

Status

()

Core
General
--
minor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ayg, Assigned: ayg)

Tracking

Trunk
mozilla18
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

The gcc version used by the try servers seems to have a problem with static_cast<bool> on an enum class.  The workaround is to replace it with a "== NS_OK" check.  In bug 783869 I avoided that by cleaning up the code, but there's a different case where that's harder/less worthwhile and it's easiest to just avoid the static_cast.
Created attachment 661190 [details] [diff] [review]
Patch

Try run containing this change in the last patch (compile only): https://tbpl.mozilla.org/?tree=Try&rev=e3e39c83c2a0
Attachment #661190 - Flags: review?(ehsan)

Updated

5 years ago
Attachment #661190 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/4b7f8d692a8c
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/4b7f8d692a8c
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.