791216 - Work around gcc enum class compiler bug

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

The gcc version used by the try servers seems to have a problem with static_cast<bool> on an enum class.  The workaround is to replace it with a "== NS_OK" check.  In bug 783869 I avoided that by cleaning up the code, but there's a different case where that's harder/less worthwhile and it's easiest to just avoid the static_cast.

Comment 1

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Attachment: Patch

Try run containing this change in the last patch (compile only): https://tbpl.mozilla.org/?tree=Try&rev=e3e39c83c2a0

Comment 2

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4b7f8d692a8c

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4b7f8d692a8c