Closed Bug 791216 Opened 12 years ago Closed 12 years ago

Work around gcc enum class compiler bug

Categories

(Core :: General, defect)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: ayg, Assigned: ayg)

References

Details

Attachments

(1 file)

The gcc version used by the try servers seems to have a problem with static_cast<bool> on an enum class.  The workaround is to replace it with a "== NS_OK" check.  In bug 783869 I avoided that by cleaning up the code, but there's a different case where that's harder/less worthwhile and it's easiest to just avoid the static_cast.
Attached patch PatchSplinter Review
Try run containing this change in the last patch (compile only): https://tbpl.mozilla.org/?tree=Try&rev=e3e39c83c2a0
Attachment #661190 - Flags: review?(ehsan)
Attachment #661190 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/4b7f8d692a8c
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.