Closed Bug 791245 Opened 7 years ago Closed 7 years ago

Must include license for ACE for webrtc code

Categories

(Core :: WebRTC, defect, blocker)

defect
Not set
blocker

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: jesup, Assigned: gerv)

References

()

Details

(Whiteboard: [WebRTC], [blocking-webrtc+], [qa-])

Attachments

(1 file)

The webrtc.org codebase includes code copied from ACE for WinXP condition variable emulation, based on http://www.cs.wustl.edu/~schmidt/win32-cv-1.html (section 3.2), with mods.

The license for that code is here: http://www1.cse.wustl.edu/~schmidt/ACE-copying.html

We may need to include the license statement, as this is confused:

   Since DOC
   software is open-source, freely available software, you are free to
   use, modify, copy, and distribute--perpetually and irrevocably--the
   DOC software source code and object code produced from the source, as
   well as copy and distribute modified versions of this software. You
   must, however, include this copyright statement along with any code
   built using DOC software that you release. No copyright statement
   needs to be provided if you just ship binary executables of your
   software products.

   You can use DOC software in commercial and/or binary software releases
   and are under no obligation to redistribute any of your source code
   that is built using DOC software. Note, however, that you may not
   misappropriate the DOC software code, such as copyrighting it yourself
   or claiming authorship of the DOC software code, in a way that will
   prevent DOC software from being distributed freely using an
   open-source development model. You needn't inform anyone that you're
   using DOC software in your software, though we encourage you to let
   [10]us know so we can promote your project in the [11]DOC software
   success stories.

The concern is about: 
   You must, however, include this copyright statement along with any code
   built using DOC software that you release. No copyright statement
   needs to be provided if you just ship binary executables of your
   software products.

Since we release source as well as binaries, I believe we're required to include the license (and it doesn't say that we only need to include it in the source, just that we don't need to include it if we *only* ship binaries.)

Odd, but it is what it is.

The current source file from webrtc.org says:
/*
 *  Use of this source code is governed by the ACE copyright license which
 *  can be found in the LICENSE file in the third_party_mods/ace directory of
 *  the source tree or at http://www1.cse.wustl.edu/~schmidt/ACE-copying.html.
 */

I don't think an http link to the copyright/license is kosher...  Could go away or change, etc.  I can file an upstream bug on that.

I need a dermination of what we need to do, and if we need to include the license I'll put up a licenses.html patch.
Whiteboard: [WebRTC], [blocking-webrtc+]
Perhaps we could contact the ACE project for clarification
We should stick something in about:license, just to be safe. However, we may be able to get away with excluding some of that rather lengthy statement which does not apply to the code.

I think we could use a narrow interpretation of "this copyright statement" and just put:


ACE(TM), TAO(TM), CIAO(TM), DAnCE(TM), and CoSMIC(TM) (henceforth referred to as "DOC software") are copyrighted by Douglas C. Schmidt and his research group at Washington University, University of California, Irvine, and Vanderbilt University, Copyright (c) 1993-2009, all rights reserved. Since DOC software is open-source, freely available software, you are free to use, modify, copy, and distribute--perpetually and irrevocably--the DOC software source code and object code produced from the source, as well as copy and distribute modified versions of this software. You must, however, include this copyright statement along with any code built using DOC software that you release. No copyright statement needs to be provided if you just ship binary executables of your software products.


Gerv
Attachment #666165 - Flags: review?(gerv)
Comment on attachment 666165 [details] [diff] [review]
Add license for ACE (windows XP condition var polyfill)

r=gerv.

Gerv
Attachment #666165 - Flags: review?(gerv) → review+
https://hg.mozilla.org/mozilla-central/rev/e8f9e7a76efa
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Whiteboard: [WebRTC], [blocking-webrtc+] → [WebRTC], [blocking-webrtc+], [qa-]
You need to log in before you can comment on or make changes to this bug.