79133 - missing image fires onerror event

Status: VERIFIED FIXED

(Core :: DOM: Events, defect)

Description

[Henrik Gemal]

If you go to:
http://gemal.dk/test/onerror.html
which uses a window.onerror function to display javascript errors you get a 
weird error saying:
error: [object KeyEvent]

The cause is a missing image. I have a <img src="help.gif"> but the image 
help.gif doesn't exit.

This is really bad.

build 20010506

Comment 1

[joki (gone)]

This one is going to be annoying.  Basically the DOM 2 spec is wrong.  It has 
img error event bubbling, which will cause this.  I'll have to think about it.  
Either we disobey the spec and don't bubble or I work around it.

Comment 2

[Brendan Eich [:brendan]]

jst, can you help?

/be

Comment 3

[Johnny Stenback (:jst)]

Taking.

Comment 4

[Johnny Stenback (:jst)]

Attachment: Proposed workaround.

Comment 5

[Johnny Stenback (:jst)]

Attached is a patch that works around the problem with the event system not
properly dealing with the flags that are passed in that would tell if certain
events should bubble or not. The patch hardcodes more event types to not bubble,
or caputer. reviews?

Comment 6

[Brendan Eich [:brendan]]

Comment on attachment 51514 [details] [diff] [review]
Proposed workaround.

r=[e-mail], but what's the bug being worked around?  Is it on file?
If so, comment its number into the patch?

/be

Comment 7

[Johnny Stenback (:jst)]

Brendan, thanks for the review. The bug being worked around is the fact that
we're not using the flags to HandleDOMEvent() as flags, Joki knows about this
and is planning on fixing it, but I don't know if there's a bug on file for it,
Joki?

Comment 8

[vidur (gone)]

Comment on attachment 51514 [details] [diff] [review]
Proposed workaround.

sr=vidur

You'd think we'd have hit problems with bubbling image onloads before this, no? Wouldn't such loads cause multiple, incorrect invocations of a window onload?

Comment 9

[Johnny Stenback (:jst)]

Fix checked in. Vidur, image onload's were actually not bubbling (they were
blocked elsewere), I added that mostly for consistency, once the real problem is
fixed we can remove all the hardcoded blocking of event bubbling...

Comment 10

[Henrik Gemal]

used http://gemal.dk/test/onerror.html to verify