791364 - Using <canvas> instead of <img> on Gaia homescreen make the homescreen crashy.

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Gaia PR https://github.com/mozilla-b2g/gaia/pull/4283 will replace <img> by <canvas> for the homescreen and as a si

Steps to reproduce:
 - Use https://github.com/mozilla-b2g/gaia/pull/4283 or wait for it to land
 - Launch the homescreen and pan for a little while between 2 pages
 
Actual result:
 - The homescreen will crash

Expected result:
 - The homescreen does not crash

cjones ask me to run: watch -n 1 'adb shell procrank | egrep "(RAM|b2g)"'  so I can see the free memory going down while panning.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

The gaia system app uses canvas, so setting this to block.  (Leaking will lead to whole-system crash, not just benign app restart.)

Kan-Ru, can you look at this?

Comment 2

[Andrew Overholt [:overholt]]

Assigning to Kan-Ru for now.

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Guys, we *really* should have fixed this bug before merging the new homescreen code.

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

I think I see the problem here.

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Free canvas front buffers that are surface descriptors

Comment 6

[Andreas Gal :gal]

Comment on attachment 661981 [details] [diff] [review]
Free canvas front buffers that are surface descriptors

I know the code pretty well and this is a pretty obvious bug. Want to move     mFrontBufferDescriptor = SurfaceDescriptor(); below the if? If its needed, it should be there. Up to you.

Comment 7

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

    mAllocator->DestroySharedSurface(&mFrontBufferDescriptor);

clears out the surface.

Comment 8

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c93a69c6d2da

Comment 9

[Graeme McCutcheon [:graememcc]]

https://hg.mozilla.org/mozilla-central/rev/c93a69c6d2da