791378 - nsPluginHost::NewPluginURLStream needs to take the privacy information into account when creating a channel on behalf of a plugin

Status: RESOLVED INVALID

(Core Graveyard :: Plug-ins, defect)

Description

[(no longer active)]

http://mxr.mozilla.org/mozilla-central/source/dom/plugins/base/nsPluginHost.cpp#3113

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 661373 [details] [diff] [review]
Patch (v1)

r=me, but this channel not being in a loadgroup is complete bullshit.  :(  Reading bug 166613 comment 20 makes me want to punch a wall or something...

Comment 3

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ebd274828b7f

Comment 4

[(no longer active)]

So after some testing, it seems like we can actually get an nsILoadContext* out of the channel's callback (and nsPluginStreamListenerPeer).  So I don't think my patch here is necessary at all (and it indeed fatally asserts in PrivateBrowsingChannel::SetPrivate).

So, I backed this out <https://hg.mozilla.org/integration/mozilla-inbound/rev/a9c81707652a> and will mark this bug as INVALID.

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/ebd274828b7f
https://hg.mozilla.org/mozilla-central/rev/a9c81707652a