Closed Bug 791378 Opened 9 years ago Closed 9 years ago

nsPluginHost::NewPluginURLStream needs to take the privacy information into account when creating a channel on behalf of a plugin

Categories

(Core :: Plug-ins, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED INVALID
mozilla18

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

Attached patch Patch (v1)Splinter Review
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #661373 - Flags: review?(bzbarsky)
Comment on attachment 661373 [details] [diff] [review]
Patch (v1)

r=me, but this channel not being in a loadgroup is complete bullshit.  :(  Reading bug 166613 comment 20 makes me want to punch a wall or something...
Attachment #661373 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/ebd274828b7f
Target Milestone: --- → mozilla18
So after some testing, it seems like we can actually get an nsILoadContext* out of the channel's callback (and nsPluginStreamListenerPeer).  So I don't think my patch here is necessary at all (and it indeed fatally asserts in PrivateBrowsingChannel::SetPrivate).

So, I backed this out <https://hg.mozilla.org/integration/mozilla-inbound/rev/a9c81707652a> and will mark this bug as INVALID.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.