If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

nsPluginHost::NewPluginURLStream needs to take the privacy information into account when creating a channel on behalf of a plugin

RESOLVED INVALID

Status

()

Core
Plug-ins
RESOLVED INVALID
5 years ago
5 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

Trunk
mozilla18
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

http://mxr.mozilla.org/mozilla-central/source/dom/plugins/base/nsPluginHost.cpp#3113
Created attachment 661373 [details] [diff] [review]
Patch (v1)
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #661373 - Flags: review?(bzbarsky)
Comment on attachment 661373 [details] [diff] [review]
Patch (v1)

r=me, but this channel not being in a loadgroup is complete bullshit.  :(  Reading bug 166613 comment 20 makes me want to punch a wall or something...
Attachment #661373 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/ebd274828b7f
Target Milestone: --- → mozilla18
So after some testing, it seems like we can actually get an nsILoadContext* out of the channel's callback (and nsPluginStreamListenerPeer).  So I don't think my patch here is necessary at all (and it indeed fatally asserts in PrivateBrowsingChannel::SetPrivate).

So, I backed this out <https://hg.mozilla.org/integration/mozilla-inbound/rev/a9c81707652a> and will mark this bug as INVALID.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → INVALID
https://hg.mozilla.org/mozilla-central/rev/ebd274828b7f
https://hg.mozilla.org/mozilla-central/rev/a9c81707652a
You need to log in before you can comment on or make changes to this bug.