Closed
Bug 791384
Opened 12 years ago
Closed 12 years ago
Update Hyphen to version 2.8.6
Categories
(Core :: Layout: Text and Fonts, defect)
Core
Layout: Text and Fonts
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: RyanVM, Assigned: RyanVM)
References
Details
Attachments
(1 file)
11.90 KB,
patch
|
jfkthame
:
review+
|
Details | Diff | Splinter Review |
Hyphen appears to be getting updates again. It's up to version 2.8.6 currently. Not a ton of changes, but might as well stay in sync.
2012-09-13 László Németh <nemeth at numbertext dot org>:
* hyphen.c: fdo#43931: removing hard hyphen hyphenation for LibreOffice
* tests/rhmin.*: add Telugu test example for rhmin fix
2012-09-11 Steven Dickson <DicksonSK at ldschurch dot org>:
* hyphen.c: fdo#54843: rhmin fix for words with 3-byte or more UTF-8
multibyte characters
2012-07-18 Caolán McNamara <caolán at redhat dot com>:
* coverity warnings
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #661378 -
Flags: review?(jfkthame)
Assignee | ||
Comment 2•12 years ago
|
||
Comment on attachment 661378 [details] [diff] [review]
Update Hyphen to version 2.8.6
I'm told Jonathan's not around. Simon, can you review?
Attachment #661378 -
Flags: review?(jfkthame) → review?(smontagu)
Comment 3•12 years ago
|
||
Comment on attachment 661378 [details] [diff] [review]
Update Hyphen to version 2.8.6
Review of attachment 661378 [details] [diff] [review]:
-----------------------------------------------------------------
Looks OK, thanks. Is there any updated README or similar to go with this?
::: intl/hyphenation/src/hyphen.c
@@ +1067,5 @@
> /* get the word with all possible hyphenations (output: hyphword) */
> void hnj_hyphen_hyphword(const char * word, int l, const char * hyphens,
> char * hyphword, char *** rep, int ** pos, int ** cut)
> {
> + int hyphenslen = l + 5;
Magic numbers like this worry me, especially without any sort of explanation. But as I don't think we actually use this function in Gecko, I guess we needn't look too closely.
Attachment #661378 -
Flags: review?(smontagu) → review+
Assignee | ||
Comment 4•12 years ago
|
||
Thanks for the review!
https://hg.mozilla.org/integration/mozilla-inbound/rev/c92665ad2811
Flags: in-testsuite-
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in
before you can comment on or make changes to this bug.
Description
•