791391 - nsUserFontSet::SyncLoadFontData needs to create the channel using the load group of the document

Status: RESOLVED INVALID

(Core :: CSS Parsing and Computation, defect)

Description

[(no longer active)]

http://mxr.mozilla.org/mozilla-central/source/layout/style/nsFontFaceLoader.cpp#859

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 661387 [details] [diff] [review]
Patch (v1)

>+++ b/layout/style/nsFontFaceLoader.cpp
>@@ -840,31 +840,36 @@ nsUserFontSet::SyncLoadFontData(gfxProxy
>   rv = CheckFontLoad(aFontToLoad, aFontFaceSrc, &principal);
>   NS_ENSURE_SUCCESS(rv, rv);
> 
>+  nsIPresShell *ps = mPresContext->PresShell();
>+  if (!ps)

CheckFontLoad already null-checked mPresContext->PresShell().

That said, this code is only reached if aFontFaceSrc is a data: URI.  So it's somewhat possible this stuff just doesn't matter.

In any case, r=me with the extraneous null-check removed.

Comment 3

[(no longer active)]

If this is only called for fonts loaded from data: URIs, then this is not needed.