nsUserFontSet::SyncLoadFontData needs to create the channel using the load group of the document

RESOLVED INVALID

Status

()

Core
CSS Parsing and Computation
RESOLVED INVALID
5 years ago
5 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

Trunk
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Comment 1

5 years ago
Created attachment 661387 [details] [diff] [review]
Patch (v1)
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #661387 - Flags: review?(bzbarsky)

Updated

5 years ago
Blocks: 787743
Comment on attachment 661387 [details] [diff] [review]
Patch (v1)

>+++ b/layout/style/nsFontFaceLoader.cpp
>@@ -840,31 +840,36 @@ nsUserFontSet::SyncLoadFontData(gfxProxy
>   rv = CheckFontLoad(aFontToLoad, aFontFaceSrc, &principal);
>   NS_ENSURE_SUCCESS(rv, rv);
> 
>+  nsIPresShell *ps = mPresContext->PresShell();
>+  if (!ps)

CheckFontLoad already null-checked mPresContext->PresShell().

That said, this code is only reached if aFontFaceSrc is a data: URI.  So it's somewhat possible this stuff just doesn't matter.

In any case, r=me with the extraneous null-check removed.
Attachment #661387 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 3

5 years ago
If this is only called for fonts loaded from data: URIs, then this is not needed.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.