791392 - mozWifiManager: expose a list of known networks

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, enhancement)

Description

[Fabien Cazenave [:kaze]]

It would be nice to expose a list of known networks — not only the currently available ones. The point would be to edit/remove networks without having to be connected to them.

Comment 1

[Andrew Overholt [:overholt]]

We discussed this at triage today.  While we agree this would be a great feature, we don't think it's a blocker.  Of course, feel free to re-nom if you disagree.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: wip

Still to-do:
  * Clean up/factor out common code in places.
  * Make explicit the relationship between a Scan Result and a Network.

This does seem to work, though!

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: patch v1

Comment 4

[Vincent Chang[:vchang][changyihsin]]

Comment on attachment 662742 [details] [diff] [review]
patch  v1

Review of attachment 662742 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/wifi/WifiWorker.js
@@ +2098,5 @@
> +      var networks = {};
> +      for (let ssid in this.configuredNetworks) {
> +        networks[ssid] = netToDOM(this.configuredNetworks[ssid]);
> +      }
> +

Do we need to send error message when ssid is not found ?

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

(In reply to Vincent Chang from comment #4)
> Do we need to send error message when ssid is not found ?

I don't understand what you mean. When which ssid isn't found where? Do you mean if there's a configured network without an ssid? That's taken care of (with an XXX comment) in _reloadConfiguredNetworks.

Comment 6

[Fabien Cazenave [:kaze]]

Works fine in Gaia: https://bugzilla.mozilla.org/show_bug.cgi?id=791392

Comment 7

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 662742 [details] [diff] [review]
patch  v1

https://hg.mozilla.org/integration/mozilla-inbound/rev/bbfb9d9241e4

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bbfb9d9241e4