791399 - Profiler tries to write to directory where it doesn't have privileges

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

It should be using the directory service to find the OS temp dir.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Use the OS tmp dir for saving files on b2g, because content processes can't write elsewhere

Comment 2

[Benoit Girard (:BenWa)]

What's the default OS tmp dir on B2G so we don't break the addons symbolication?

https://github.com/bgirard/Gecko-Profiler-Addon/blob/master/lib/main.js#L602

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

The profiler addon is 100% broken already, so it really doesn't matter.

At any rate, it's /data/local/tmp.

Comment 4

[Benoit Girard (:BenWa)]

(In reply to Chris Jones [:cjones] [:warhammer] from comment #3)
> The profiler addon is 100% broken already, so it really doesn't matter.
> 
> At any rate, it's /data/local/tmp.

Not exactly, glandium has a working build that's gated on some dependent patches so I want to coordinate any landing to not break his changes.

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

glandium, see comment 3 and comment 4.  I hope we haven't been duplicating effort! ;)

Comment 6

[Mike Hommey [:glandium]]

I'm not touching that part, so you can land safely, but just know this will go away soonish.

Comment 7

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Please don't tell me that that's because we'll be sending JS sample objects through the debug protocol :(.

Comment 8

[Mike Hommey [:glandium]]

(In reply to Chris Jones [:cjones] [:warhammer] from comment #7)
> Please don't tell me that that's because we'll be sending JS sample objects
> through the debug protocol :(.

It is. Any particular problem with that ?

Comment 9

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Bug 789667.  We'll probably have to bump the sample buffer size down on b2g again :(.

Comment 10

[Mike Hommey [:glandium]]

(In reply to Chris Jones [:cjones] [:warhammer] from comment #9)
> Bug 789667.  We'll probably have to bump the sample buffer size down on b2g
> again :(.

Note the debug protocol will allow to adjust sizes dynamically.

Comment 11

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

https://hg.mozilla.org/integration/mozilla-inbound/rev/072674dbb5c7

Comment 12

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/072674dbb5c7