Closed Bug 791399 Opened 7 years ago Closed 7 years ago

Profiler tries to write to directory where it doesn't have privileges

Categories

(Core :: Gecko Profiler, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: cjones, Assigned: cjones)

Details

Attachments

(1 file)

It should be using the directory service to find the OS temp dir.
What's the default OS tmp dir on B2G so we don't break the addons symbolication?

https://github.com/bgirard/Gecko-Profiler-Addon/blob/master/lib/main.js#L602
The profiler addon is 100% broken already, so it really doesn't matter.

At any rate, it's /data/local/tmp.
(In reply to Chris Jones [:cjones] [:warhammer] from comment #3)
> The profiler addon is 100% broken already, so it really doesn't matter.
> 
> At any rate, it's /data/local/tmp.

Not exactly, glandium has a working build that's gated on some dependent patches so I want to coordinate any landing to not break his changes.
Attachment #661400 - Flags: review?(bgirard) → review+
glandium, see comment 3 and comment 4.  I hope we haven't been duplicating effort! ;)
I'm not touching that part, so you can land safely, but just know this will go away soonish.
Please don't tell me that that's because we'll be sending JS sample objects through the debug protocol :(.
(In reply to Chris Jones [:cjones] [:warhammer] from comment #7)
> Please don't tell me that that's because we'll be sending JS sample objects
> through the debug protocol :(.

It is. Any particular problem with that ?
Bug 789667.  We'll probably have to bump the sample buffer size down on b2g again :(.
(In reply to Chris Jones [:cjones] [:warhammer] from comment #9)
> Bug 789667.  We'll probably have to bump the sample buffer size down on b2g
> again :(.

Note the debug protocol will allow to adjust sizes dynamically.
https://hg.mozilla.org/mozilla-central/rev/072674dbb5c7
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.