Closed
Bug 791426
Opened 12 years ago
Closed 12 years ago
Update trychooser
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: philor, Assigned: philor)
References
Details
(Whiteboard: [sheriff-want])
Attachments
(2 files)
11.21 KB,
patch
|
armenzg
:
review+
philor
:
checked-in+
|
Details | Diff | Splinter Review |
1.18 KB,
text/x-python
|
Details |
Because omg. Platforms: the b2g listed there isn't the b2g we build, because that's a product rather than a platform; linuxqt doesn't exist; android-xul doesn't exist; macosx (the 10.5 flavor) doesn't exist. Unit tests: reftest-no-accel is linux+win7 only; mozmill hasn't existed for eons unless that's choosing the Thunderbird mozmill, in which case it should say so; opengl hasn't existed since it became the default; peptest doesn't exist; android has 4 reftest hunks; android crashtest-1 doesn't exist; android browser-chrome was xul-only, so it doesn't exist. Talos: as the link to the current configs will show, nearly all of them are wrong (pretty sure in the case of desktop trunk, every single one is).
Assignee | ||
Comment 1•12 years ago
|
||
Platforms: my guess that I would get Android Armv6 with -p android turns out to have been mistaken, not sure what actually chooses it.
Updated•12 years ago
|
Whiteboard: [sheriff-want]
Assignee | ||
Comment 2•12 years ago
|
||
Not surprisingly, android-armv6. And while I wasn't paying attention, we seem to have gotten tired of what we once did, running talos suites on try until that suite wasn't run on any branch anymore, so now the set of suites that should be listed is just those that are enable_by_default plus xperf, which means that of those talos suites trychooser lists, exactly xperf and nothing else can actually be run.
Assignee | ||
Comment 3•12 years ago
|
||
I think this covers it all; I'm certain it gets us a whole lot closer to reality.
Attachment #661660 -
Flags: review?(armenzg)
Updated•12 years ago
|
Attachment #661660 -
Flags: review?(armenzg) → review+
Comment 4•12 years ago
|
||
Thanks philor for your help. Please let me know if you would like me to land and/or deploy it. I've a script that I believe with more time and dedication can be turned into a great tool to keep this up-to-date. I'm publishing it in case it is of use for you and/or someone would like to push it forward.
Assignee | ||
Comment 5•12 years ago
|
||
Comment on attachment 661660 [details] [diff] [review] fix v.1 Landed in http://hg.mozilla.org/build/tools/rev/464dcbdcbc2d - yes, please do deploy it for me. Though your script reminds me that I didn't add android-noion - I'll have to remember to do that in a few days, if the forthcoming tests on armv6 don't turn out to be enough to replace the need for it.
Attachment #661660 -
Flags: checked-in+
Comment 6•12 years ago
|
||
[root@relengweb1.dmz.scl3 tools]# hg id 464dcbdcbc2d tip Let me know if you have more changes to review or deploy.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 7•12 years ago
|
||
[root@relengweb1.dmz.scl3 tools]# hg id 1aee438e4348 tip Fixed a missing quote. http://hg.mozilla.org/build/tools/rev/1aee438e4348
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
Updated•8 years ago
|
Component: Tools → General
You need to log in
before you can comment on or make changes to this bug.
Description
•