791574 - Use a Unix-compatible list2cmdline in jstests.py

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Steve Fink [:sfink] [:s:]]

Sadly, subprocess.list2cmdline only seems to do something sensible for Windows, which I find rather bizarre.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Use a Unix-compatible list2cmdline

This patch fixes the problem where -s can give you something like

  ./js -e option(\'allow_xml\'); -f ...

which is totally invalid in bash.

Comment 2

[Terrence Cole [:terrence]]

Comment on attachment 661628 [details] [diff] [review]
Use a Unix-compatible list2cmdline

Review of attachment 661628 [details] [diff] [review]:
-----------------------------------------------------------------

That is indeed totally bizarre.

::: js/src/tests/lib/results.py
@@ +5,5 @@
> +if (sys.platform.startswith('linux') or
> +    sys.platform.startswith('darwin')
> +   ):
> +    import pipes
> +    list2cmdline = lambda args: ' '.join([ pipes.quote(a) for a in args ])

Neat trick!  I had no idea pipes even existed.  If quote works correct on Windows as well, just use this variant unconditionally.

Comment 3

[Steve Fink [:sfink] [:s:]]

(In reply to Terrence Cole [:terrence] from comment #2)
> Neat trick!  I had no idea pipes even existed.

Me neither, but Our Benevolent Overlord Google does.

> If quote works correct on Windows as well, just use this variant unconditionally.

That's a good point. It seems to, since MozillaBuild gives you a bash shell anyway. I didn't have a working shell on Windows, but it generally seemed to work, so I'll do that. Thanks. It can't be any worse than what it does now.

Comment 4

[Steve Fink [:sfink] [:s:]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/ea2e059c896b

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ea2e059c896b

Comment 6

[Jeff Hammel]

we may want to put this in e.g. mozfile at this point