791612 - "other origin" bar persists after pressing Back button to return to same-origin page

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect, P1)

Description

[Myk Melez [:myk] [@mykmelez]]

Attachment: screenshot

If you go from a page in a webapp's origin to a page in another origin, then press the Android Back button to return to the page in the webapp's origin, the "other origin" bar doesn't go away.

Steps to Reproduce:

1. install and open the Firefox Marketplace app;
2. tap the "Log in / Register" button to go to a page at the origin https://login.persona.org;
3. tap the Android Back button.

Expected Results: the origin bar disappears.

Actual Results: the origin bar persists (and continues to show the origin https://login.persona.org).

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Patch

In this case we're actually closing a tab and selection an old tab. No "location change" event fires. I think we probably want to update this any time the selected tab changes though.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 663171 [details] [diff] [review]
Patch

Agreed

Comment 3

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/71b59b120de8

Comment 4

[Wesley Johnston (:wesj)]

Comment on attachment 663171 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 771915
User impact if declined: Other origin bar persists some times when it shouldn't
Testing completed (on m-c, etc.): Landed on mc today
Risk to taking this patch (and alternatives if risky): Very low risk. Webapp only fix for a situation that's fairly rare.
String or UUID changes made by this patch: None.

Comment 5

[Alex Keybl [:akeybl]]

Comment on attachment 663171 [details] [diff] [review]
Patch

[Triage Comment]
Bug fix for new feature - approving for Aurora 17.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/71b59b120de8

Comment 7

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9d03aa5abb5a