Last Comment Bug 791612 - "other origin" bar persists after pressing Back button to return to same-origin page
: "other origin" bar persists after pressing Back button to return to same-orig...
Product: Firefox for Android
Classification: Client Software
Component: Web Apps (show other bugs)
: unspecified
: ARM Android
P1 normal (vote)
: Firefox 18
Assigned To: Wesley Johnston (:wesj)
: Aaron Train [:aaronmt]
: Myk Melez [:myk] [@mykmelez]
Depends on:
  Show dependency treegraph
Reported: 2012-09-16 22:47 PDT by Myk Melez [:myk] [@mykmelez]
Modified: 2012-10-06 00:20 PDT (History)
4 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

screenshot (248.50 KB, image/png)
2012-09-16 22:47 PDT, Myk Melez [:myk] [@mykmelez]
no flags Details
Patch (932 bytes, patch)
2012-09-20 14:38 PDT, Wesley Johnston (:wesj)
mark.finkle: review+
akeybl: approval‑mozilla‑aurora+
Details | Diff | Splinter Review

Description User image Myk Melez [:myk] [@mykmelez] 2012-09-16 22:47:03 PDT
Created attachment 661697 [details]

If you go from a page in a webapp's origin to a page in another origin, then press the Android Back button to return to the page in the webapp's origin, the "other origin" bar doesn't go away.

Steps to Reproduce:

1. install and open the Firefox Marketplace app;
2. tap the "Log in / Register" button to go to a page at the origin;
3. tap the Android Back button.

Expected Results: the origin bar disappears.

Actual Results: the origin bar persists (and continues to show the origin
Comment 1 User image Wesley Johnston (:wesj) 2012-09-20 14:38:48 PDT
Created attachment 663171 [details] [diff] [review]

In this case we're actually closing a tab and selection an old tab. No "location change" event fires. I think we probably want to update this any time the selected tab changes though.
Comment 2 User image Mark Finkle (:mfinkle) (use needinfo?) 2012-09-20 19:42:02 PDT
Comment on attachment 663171 [details] [diff] [review]

Comment 4 User image Wesley Johnston (:wesj) 2012-09-24 08:58:20 PDT
Comment on attachment 663171 [details] [diff] [review]

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 771915
User impact if declined: Other origin bar persists some times when it shouldn't
Testing completed (on m-c, etc.): Landed on mc today
Risk to taking this patch (and alternatives if risky): Very low risk. Webapp only fix for a situation that's fairly rare.
String or UUID changes made by this patch: None.
Comment 5 User image Alex Keybl [:akeybl] 2012-09-24 16:14:54 PDT
Comment on attachment 663171 [details] [diff] [review]

[Triage Comment]
Bug fix for new feature - approving for Aurora 17.
Comment 6 User image Ryan VanderMeulen [:RyanVM] 2012-09-24 17:55:58 PDT
Comment 7 User image Wesley Johnston (:wesj) 2012-10-05 18:16:11 PDT

Note You need to log in before you can comment on or make changes to this bug.