791644 - Clean up GetResultingTransformMatrix

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Matt Woodrow (:mattwoodrow)]

Attachment: Split it into two functions

This takes way too many optional parameters.

Attached patch improves the situation (I think), still wouldn't call it pretty, but it's progress.

Comment 1

[Matt Woodrow (:mattwoodrow)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c2b7be27e412

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Backed out for causing mochitest-4 failures. Please run this through Try before trying to push again.
https://hg.mozilla.org/integration/mozilla-inbound/rev/a80f28d6ac93

https://tbpl.mozilla.org/php/getParsedLog.php?id=15286772&tree=Mozilla-Inbound

15998 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/base/tests/test_bug677878.html | Test timed out.
16006 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/base/tests/test_bug718809.html | Incorrect bounding rect - got -17895698, expected 0
16007 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/base/tests/test_bug718809.html | Incorrect bounding rect - got -17895698, expected 0
16008 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/base/tests/test_bug718809.html | Incorrect bounding rect - got -35791396, expected 100
16009 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/base/tests/test_bug718809.html | Incorrect bounding rect - got -35791396, expected 50
16012 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/base/tests/test_bug725426.html | Incorrect bounding rect top - got -17895698, expected 0
16013 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/base/tests/test_bug725426.html | Incorrect bounding rect top - got -35791396, expected 100
16014 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/base/tests/test_bug725426.html | Incorrect bounding rect top - got -35791396, expected 100
16015 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/base/tests/test_bug725426.html | Incorrect bounding rect top - got -17895698, expected 0
16018 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/base/tests/test_bug731777.html | Able to hit transformed object - got [object HTMLDivElement], expected [object HTMLDivElement]
16019 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/base/tests/test_bug731777.html | Able to hit transformed object - got [object HTMLDivElement], expected [object HTMLDivElement]
16093 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/base/tests/test_event_target_radius.html | checking 't4' offset -1,10 [translated DIV]; got null
16709 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/base/tests/test_preserve3d_sorting_hit_testing.html | point (650, 250): Small object should be infront of big - got [object HTMLDivElement], expected [object HTMLDivElement]
Bug 717868 - [SeaMonkey] mochitest-plain-4: "test_reftests_with_caret.html | finished in a non-clean fashion" (in /tests/layout/base/tests/test_preserve3d_sorting_hit_testing.html) 16710 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/base/tests/test_preserve3d_sorting_hit_testing.html | point (650, 308): Check bounds of small object - got [object HTMLDivElement], expected [object HTMLDivElement]
Bug 717868 - [SeaMonkey] mochitest-plain-4: "test_reftests_with_caret.html | finished in a non-clean fashion" (in /tests/layout/base/tests/test_preserve3d_sorting_hit_testing.html) 16711 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/base/tests/test_preserve3d_sorting_hit_testing.html | point (650, 207): Check bounds of small object - got [object HTMLDivElement], expected [object HTMLDivElement]
Bug 717868 - [SeaMonkey] mochitest-plain-4: "test_reftests_with_caret.html | finished in a non-clean fashion" (in /tests/layout/base/tests/test_preserve3d_sorting_hit_testing.html) 16712 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/base/tests/test_preserve3d_sorting_hit_testing.html | point (607, 250): Check bounds of small object - got [object HTMLDivElement], expected [object HTMLDivElement]
Bug 717868 - [SeaMonkey] mochitest-plain-4: "test_reftests_with_caret.html | finished in a non-clean fashion" (in /tests/layout/base/tests/test_preserve3d_sorting_hit_testing.html) 16713 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/base/tests/test_preserve3d_sorting_hit_testing.html | point (708, 250): Check bounds of small object - got [object HTMLDivElement], expected [object HTMLDivElement]
Bug 717868 - [SeaMonkey] mochitest-plain-4: "test_reftests_with_caret.html | finished in a non-clean fashion" (in /tests/layout/base/tests/test_preserve3d_sorting_hit_testing.html) 18013 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_bug524925.html | Overflow areas should update after dynamic transform changes - got 100, expected 150

Comment 3

[Matt Woodrow (:mattwoodrow)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/508487665424

https://tbpl.mozilla.org/?tree=Try&rev=d16d0763ca8f

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/508487665424