791674 - B2G RIL: Revise (U)Sim Service Table

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

In ril_worker.js, the function getUST() is used to get USIM Service Table,
but for 2G SIM, the name is 'SIM Service Table'.
In order to make this function to be more appropriate to general ICC,
I think we should rename this function to a more generalized term.

Also we need to revise the util function isUSTServiceAvailable,
since the response of SST is different from UST.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 1: Update RilContext

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 2: Update ril_worker

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 3: Test case

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 1: Update RilContext v2

removed sst in RilContext

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 2: Update ril_worker v2

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 3: Test case v2

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 2: Update ril_worker v3

Comment 8

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 3: Test case v3

Comment 9

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 662112 [details] [diff] [review]
Part 2: Update ril_worker v3

Review of attachment 662112 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/ril_consts.js
@@ +707,5 @@
> +const GECKO_ICC_SERVICE_BDN = 1;
> +const GECKO_ICC_SERVICE_FDN = 2;
> +const GECKO_ICC_SERVICE_SDN = 3;
> +const GECKO_ICC_SERVICES = [
> +  // GECKO_ICC_SERVICES_*,    SIM, USIM

I think we can move /* GECKO_ICC_SERVICE_ADN */ to the end. This way, we don't have to change other lines at adding a longer-in-length Gecko ICC service constant.

::: dom/system/gonk/ril_worker.js
@@ +1255,4 @@
>    },
>  
>    /**
> +   * Read the (U)SIM Service Tablefrom the ICC.

"Table from"

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 662009 [details] [diff] [review]
Part 1: Update RilContext v2

You should update the uuid when changing interfaces.

Comment 11

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

(In reply to Olli Pettay [:smaug] from comment #10)
> Comment on attachment 662009 [details] [diff] [review]
> Part 1: Update RilContext v2
> 
> You should update the uuid when changing interfaces.

Thanks for catching that, will update the patch now

Comment 12

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 1: Update RilContext v3

update uuid

Comment 13

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 2: Update ril_worker v4

Comment 14

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 3: Test case v4

Comment 15

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 3: Test case v5

Fixed typo.

Comment 16

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2f54fc19d5a3
https://hg.mozilla.org/integration/mozilla-inbound/rev/fbda4b18bc65
https://hg.mozilla.org/integration/mozilla-inbound/rev/6bc8df58ddcf

Comment 17

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/2f54fc19d5a3
https://hg.mozilla.org/mozilla-central/rev/fbda4b18bc65
https://hg.mozilla.org/mozilla-central/rev/6bc8df58ddcf