Closed
Bug 791674
Opened 9 years ago
Closed 9 years ago
B2G RIL: Revise (U)Sim Service Table
Categories
(Core :: DOM: Events, defect)
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: allstars.chh, Assigned: allstars.chh)
Details
Attachments
(3 files, 9 obsolete files)
1.35 KB,
patch
|
Details | Diff | Splinter Review | |
6.22 KB,
patch
|
Details | Diff | Splinter Review | |
1.28 KB,
patch
|
Details | Diff | Splinter Review |
In ril_worker.js, the function getUST() is used to get USIM Service Table, but for 2G SIM, the name is 'SIM Service Table'. In order to make this function to be more appropriate to general ICC, I think we should rename this function to a more generalized term. Also we need to revise the util function isUSTServiceAvailable, since the response of SST is different from UST.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → allstars.chh
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #661997 -
Flags: review?(vyang)
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #661998 -
Flags: review?(vyang)
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #661999 -
Flags: review?(vyang)
Assignee | ||
Comment 4•9 years ago
|
||
removed sst in RilContext
Attachment #661997 -
Attachment is obsolete: true
Attachment #661997 -
Flags: review?(vyang)
Attachment #662009 -
Flags: review?(vyang)
Assignee | ||
Comment 5•9 years ago
|
||
Attachment #661998 -
Attachment is obsolete: true
Attachment #661998 -
Flags: review?(vyang)
Attachment #662010 -
Flags: review?(vyang)
Assignee | ||
Comment 6•9 years ago
|
||
Attachment #661999 -
Attachment is obsolete: true
Attachment #661999 -
Flags: review?(vyang)
Attachment #662011 -
Flags: review?(vyang)
Updated•9 years ago
|
Attachment #662009 -
Flags: review?(vyang) → review+
Assignee | ||
Comment 7•9 years ago
|
||
Attachment #662010 -
Attachment is obsolete: true
Attachment #662010 -
Flags: review?(vyang)
Attachment #662112 -
Flags: review?(vyang)
Assignee | ||
Comment 8•9 years ago
|
||
Attachment #662011 -
Attachment is obsolete: true
Attachment #662011 -
Flags: review?(vyang)
Attachment #662114 -
Flags: review?(vyang)
Comment 9•9 years ago
|
||
Comment on attachment 662112 [details] [diff] [review] Part 2: Update ril_worker v3 Review of attachment 662112 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/system/gonk/ril_consts.js @@ +707,5 @@ > +const GECKO_ICC_SERVICE_BDN = 1; > +const GECKO_ICC_SERVICE_FDN = 2; > +const GECKO_ICC_SERVICE_SDN = 3; > +const GECKO_ICC_SERVICES = [ > + // GECKO_ICC_SERVICES_*, SIM, USIM I think we can move /* GECKO_ICC_SERVICE_ADN */ to the end. This way, we don't have to change other lines at adding a longer-in-length Gecko ICC service constant. ::: dom/system/gonk/ril_worker.js @@ +1255,4 @@ > }, > > /** > + * Read the (U)SIM Service Tablefrom the ICC. "Table from"
Attachment #662112 -
Flags: review?(vyang) → review+
Updated•9 years ago
|
Attachment #662114 -
Flags: review?(vyang) → review+
Comment 10•9 years ago
|
||
Comment on attachment 662009 [details] [diff] [review] Part 1: Update RilContext v2 You should update the uuid when changing interfaces.
Assignee | ||
Comment 11•9 years ago
|
||
(In reply to Olli Pettay [:smaug] from comment #10) > Comment on attachment 662009 [details] [diff] [review] > Part 1: Update RilContext v2 > > You should update the uuid when changing interfaces. Thanks for catching that, will update the patch now
Assignee | ||
Comment 13•9 years ago
|
||
Attachment #662112 -
Attachment is obsolete: true
Assignee | ||
Comment 14•9 years ago
|
||
Attachment #662114 -
Attachment is obsolete: true
Assignee | ||
Comment 16•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2f54fc19d5a3 https://hg.mozilla.org/integration/mozilla-inbound/rev/fbda4b18bc65 https://hg.mozilla.org/integration/mozilla-inbound/rev/6bc8df58ddcf
Target Milestone: --- → mozilla18
Comment 17•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2f54fc19d5a3 https://hg.mozilla.org/mozilla-central/rev/fbda4b18bc65 https://hg.mozilla.org/mozilla-central/rev/6bc8df58ddcf
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•