Closed Bug 791674 Opened 7 years ago Closed 7 years ago

B2G RIL: Revise (U)Sim Service Table

Categories

(Core :: DOM: Events, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: allstars.chh, Assigned: allstars.chh)

Details

Attachments

(3 files, 9 obsolete files)

1.35 KB, patch
Details | Diff | Splinter Review
6.22 KB, patch
Details | Diff | Splinter Review
1.28 KB, patch
Details | Diff | Splinter Review
In ril_worker.js, the function getUST() is used to get USIM Service Table,
but for 2G SIM, the name is 'SIM Service Table'.
In order to make this function to be more appropriate to general ICC,
I think we should rename this function to a more generalized term.

Also we need to revise the util function isUSTServiceAvailable,
since the response of SST is different from UST.
Assignee: nobody → allstars.chh
Status: NEW → ASSIGNED
Attached patch Part 1: Update RilContext (obsolete) — Splinter Review
Attachment #661997 - Flags: review?(vyang)
Attached patch Part 2: Update ril_worker (obsolete) — Splinter Review
Attachment #661998 - Flags: review?(vyang)
Attached patch Part 3: Test case (obsolete) — Splinter Review
Attachment #661999 - Flags: review?(vyang)
Attached patch Part 1: Update RilContext v2 (obsolete) — Splinter Review
removed sst in RilContext
Attachment #661997 - Attachment is obsolete: true
Attachment #661997 - Flags: review?(vyang)
Attachment #662009 - Flags: review?(vyang)
Attached patch Part 2: Update ril_worker v2 (obsolete) — Splinter Review
Attachment #661998 - Attachment is obsolete: true
Attachment #661998 - Flags: review?(vyang)
Attachment #662010 - Flags: review?(vyang)
Attached patch Part 3: Test case v2 (obsolete) — Splinter Review
Attachment #661999 - Attachment is obsolete: true
Attachment #661999 - Flags: review?(vyang)
Attachment #662011 - Flags: review?(vyang)
Attachment #662009 - Flags: review?(vyang) → review+
Attached patch Part 2: Update ril_worker v3 (obsolete) — Splinter Review
Attachment #662010 - Attachment is obsolete: true
Attachment #662010 - Flags: review?(vyang)
Attachment #662112 - Flags: review?(vyang)
Attached patch Part 3: Test case v3 (obsolete) — Splinter Review
Attachment #662011 - Attachment is obsolete: true
Attachment #662011 - Flags: review?(vyang)
Attachment #662114 - Flags: review?(vyang)
No longer blocks: 778993
Comment on attachment 662112 [details] [diff] [review]
Part 2: Update ril_worker v3

Review of attachment 662112 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/ril_consts.js
@@ +707,5 @@
> +const GECKO_ICC_SERVICE_BDN = 1;
> +const GECKO_ICC_SERVICE_FDN = 2;
> +const GECKO_ICC_SERVICE_SDN = 3;
> +const GECKO_ICC_SERVICES = [
> +  // GECKO_ICC_SERVICES_*,    SIM, USIM

I think we can move /* GECKO_ICC_SERVICE_ADN */ to the end. This way, we don't have to change other lines at adding a longer-in-length Gecko ICC service constant.

::: dom/system/gonk/ril_worker.js
@@ +1255,4 @@
>    },
>  
>    /**
> +   * Read the (U)SIM Service Tablefrom the ICC.

"Table from"
Attachment #662112 - Flags: review?(vyang) → review+
Attachment #662114 - Flags: review?(vyang) → review+
Comment on attachment 662009 [details] [diff] [review]
Part 1: Update RilContext v2

You should update the uuid when changing interfaces.
(In reply to Olli Pettay [:smaug] from comment #10)
> Comment on attachment 662009 [details] [diff] [review]
> Part 1: Update RilContext v2
> 
> You should update the uuid when changing interfaces.

Thanks for catching that, will update the patch now
update uuid
Attachment #662009 - Attachment is obsolete: true
Attached patch Part 3: Test case v4 (obsolete) — Splinter Review
Attachment #662114 - Attachment is obsolete: true
Fixed typo.
Attachment #662412 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.