Closed Bug 791674 Opened 7 years ago Closed 7 years ago
B2G RIL: Revise (U)Sim Service Table
In ril_worker.js, the function getUST() is used to get USIM Service Table, but for 2G SIM, the name is 'SIM Service Table'. In order to make this function to be more appropriate to general ICC, I think we should rename this function to a more generalized term. Also we need to revise the util function isUSTServiceAvailable, since the response of SST is different from UST.
7 years ago
Assignee: nobody → allstars.chh
Status: NEW → ASSIGNED
removed sst in RilContext
Attachment #662009 - Flags: review?(vyang) → review+
Comment on attachment 662112 [details] [diff] [review] Part 2: Update ril_worker v3 Review of attachment 662112 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/system/gonk/ril_consts.js @@ +707,5 @@ > +const GECKO_ICC_SERVICE_BDN = 1; > +const GECKO_ICC_SERVICE_FDN = 2; > +const GECKO_ICC_SERVICE_SDN = 3; > +const GECKO_ICC_SERVICES = [ > + // GECKO_ICC_SERVICES_*, SIM, USIM I think we can move /* GECKO_ICC_SERVICE_ADN */ to the end. This way, we don't have to change other lines at adding a longer-in-length Gecko ICC service constant. ::: dom/system/gonk/ril_worker.js @@ +1255,4 @@ > }, > > /** > + * Read the (U)SIM Service Tablefrom the ICC. "Table from"
Attachment #662112 - Flags: review?(vyang) → review+
Attachment #662114 - Flags: review?(vyang) → review+
Comment on attachment 662009 [details] [diff] [review] Part 1: Update RilContext v2 You should update the uuid when changing interfaces.
(In reply to Olli Pettay [:smaug] from comment #10) > Comment on attachment 662009 [details] [diff] [review] > Part 1: Update RilContext v2 > > You should update the uuid when changing interfaces. Thanks for catching that, will update the patch now
Attachment #662009 - Attachment is obsolete: true
Attachment #662412 - Attachment is obsolete: true
https://hg.mozilla.org/integration/mozilla-inbound/rev/2f54fc19d5a3 https://hg.mozilla.org/integration/mozilla-inbound/rev/fbda4b18bc65 https://hg.mozilla.org/integration/mozilla-inbound/rev/6bc8df58ddcf
Target Milestone: --- → mozilla18
https://hg.mozilla.org/mozilla-central/rev/2f54fc19d5a3 https://hg.mozilla.org/mozilla-central/rev/fbda4b18bc65 https://hg.mozilla.org/mozilla-central/rev/6bc8df58ddcf
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.