Closed
Bug 791715
Opened 13 years ago
Closed 13 years ago
Device Storage - Ensure device storage is only used by webapps
Categories
(Core :: DOM: Device Interfaces, defect)
Core
DOM: Device Interfaces
Tracking
()
People
(Reporter: dougt, Assigned: dougt)
Details
(Whiteboard: [LOE:S])
Attachments
(1 file, 2 obsolete files)
|
4.34 KB,
patch
|
sicking
:
review+
|
Details | Diff | Splinter Review |
So no need to hook up any additional prompts, the existing prompt should be fine. Just add a call to permissionManager->testExactPermissionFromPrincipal(principal, "webapps-manager") to the getDeviceStorage if the type is "apps".
|
Assignee | |
Updated•13 years ago
|
Summary: Devi → Device Storage - Ensure device storage is only used by webapps
|
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → doug.turner
blocking-basecamp: --- → ?
|
||
Updated•13 years ago
|
blocking-basecamp: ? → +
|
|
Assignee | |
Comment 1•13 years ago
|
||
is this what you had in mind?
Attachment #661927 -
Flags: feedback?(jonas)
|
|
Assignee | |
Comment 2•13 years ago
|
||
Comment on attachment 661927 [details] [diff] [review]
patch v.1
per irc.
Attachment #661927 -
Flags: feedback?(jonas) → feedback-
|
|
Assignee | |
Comment 3•13 years ago
|
||
something closer to what sicking was asking for.
Attachment #661927 -
Attachment is obsolete: true
Attachment #662026 -
Flags: review?(jonas)
|
|
Assignee | |
Comment 4•13 years ago
|
||
Comment on attachment 662026 [details] [diff] [review]
patch v.1
tabs. fml
Attachment #662026 -
Flags: review?(jonas) → review-
|
|
Assignee | |
Comment 5•13 years ago
|
||
Attachment #662026 -
Attachment is obsolete: true
Attachment #662027 -
Flags: review?(jonas)
|
|
Assignee | |
Updated•13 years ago
|
Whiteboard: LOE:s
|
|
||
Updated•13 years ago
|
Whiteboard: LOE:s → [LOE:S]
Comment on attachment 662027 [details] [diff] [review]
patch v.1
Review of attachment 662027 [details] [diff] [review]:
-----------------------------------------------------------------
r=me, but do ensure to land this in the same patch as the actual "apps" support so that we don't back out one and not the other. And so it's more clear how things work when someone is looking at hg history.
Attachment #662027 -
Flags: review?(jonas) → review+
|
|
Assignee | |
Comment 7•13 years ago
|
||
|
||
Comment 8•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in
before you can comment on or make changes to this bug.
Description
•