791777 - Remove NS_finite() and use mozilla::IsFinite

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[William Pitcock]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:15.0) Gecko/20100101 Firefox/15.0.1
Build ID: 20120905151427

Steps to reproduce:

::isfinite() / std::isfinite() is supported across all platforms other than windows as it is a component of both C99 and POSIX 2008.

Comment 1

[Andrew McCreight [:mccr8]]

Nathan suggested: "I think a more reasonable thing to do would be to remove NS_finite completely and use mozilla::IsFinite from mfbt/FloatingPoint.h."

Anuj expressed some interest in this.  Let me know if you need some help figuring this out, I'll try taking a look at the relevant code in the next day or two.

Comment 2

[Anuj Agarwal [:anujagarwal464]]

Attachment: bug791777-part1.diff

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 8496029 [details] [diff] [review]
bug791777-part1.diff

Review of attachment 8496029 [details] [diff] [review]:
-----------------------------------------------------------------

This looks like a good start.  I'm assuming you're planning on replacing the other instances, too?

Comment 4

[Andrew McCreight [:mccr8]]

I suggested he start with one file and get feedback on it to make sure he was on the right track before writing the full patch. :)

Comment 5

[Anuj Agarwal [:anujagarwal464]]

Attachment: bug791777.diff

Try: https://tbpl.mozilla.org/?tree=Try&rev=1d6c319d80ea

Comment 6

[Nathan Froyd [:froydnj]]

Comment on attachment 8496177 [details] [diff] [review]
bug791777.diff

Review of attachment 8496177 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the changes below.

::: content/base/public/nsContentUtils.h
@@ +2356,5 @@
>   * series of additions will not be finite if any one of the operands in the
>   * series is not finite.
>   */
>  #define NS_ENSURE_FINITE(f, rv)                                               \
> +  if (!IsFinite(f)) {                                                        \

These NS_ENSURE_FINITE* macros should use the mozilla:: prefix on IsFinite to avoid namespace conflicts.

Also, please indent the trailing slashes on the lines you change to line up with the rest of the trailing slashes in the macro.

Comment 7

[Anuj Agarwal [:anujagarwal464]]

Attachment: bug791777.diff r=froydnj

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/366b01141df5

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/366b01141df5