791928 - [b2g-bluetooth] Broadcast bonding-related events with device name

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Gina Yeh [:gyeh] [:ginayeh]]

As shown in the UX spec of settings app, device name should be shown when there's a pairing request comes. Since the settings app is launched after receiving the system message like onrequestconfirmation, there's no way to get device attributes from the instance of BluetoothDevice. So, we need to broadcast system message with device name.

Comment 1

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: v1: Broadcast bonding-related events with device name

Reuse class DevicePropertiesSignalHandler to retrieve device name and change the argument to a BluetoothSignal consist of signalName, signalPath, and BluetoothValue.

When we get "DeviceCreated", BluetoothValue is a nsString, the object path of device, and return a dict of device properties back to BluetoothDevice. 

When we get "RequestConfirmation"/"RequestPinCode"/"RequestPasskey", BluetoothValue is an array of BluetoothNamedValue, including object path of device and passkey (only for "RequestConfirmation"), and append device name only to original parameters.

Comment 2

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Final version: Broadcast bonding-related events with device name, r=qdot

try server: https://tbpl.mozilla.org/?tree=Try&rev=4f72a000a8fc

Comment 3

[Eric Chou [:ericchou] [:echou]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e5dda6269c22

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e5dda6269c22