Closed
Bug 792002
Opened 9 years ago
Closed 8 years ago
[b2g-bluetooth] Implement HFP message handler
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
People
(Reporter: echou, Assigned: echou)
References
Details
(Whiteboard: [LOE:S])
Attachments
(2 files, 5 obsolete files)
We need a message handler to establish SLC connection with remote headset and respond to other commands sent from headset. Reference: Bluetooth Hands-free Profile 1.6
Assignee | ||
Updated•9 years ago
|
Assignee | ||
Comment 1•9 years ago
|
||
Basic HFP handler, haven't kept remote device information yet, but it's enough to establish a SLC connection.
Comment 2•8 years ago
|
||
Comment on attachment 662132 [details] [diff] [review] patch 1: v1: HFP message handler, basic functionalities Review of attachment 662132 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, but same issue, waiting for my socket stuff to land, so delaying my r+ until then. Will put these patches on top of my socket work for testing though. Thanks!
Assignee | ||
Comment 3•8 years ago
|
||
Attachment #662132 -
Attachment is obsolete: true
Attachment #662132 -
Flags: review?(kyle)
Assignee | ||
Comment 4•8 years ago
|
||
Slightly modified comments at the AT+CIND handler. There is a TODO item, and I decided to put this on another issue.
Attachment #662392 -
Attachment is obsolete: true
Assignee | ||
Comment 5•8 years ago
|
||
To adjust volume and let volume change dialog pop up, first, I make Shell.js listen to topic "bluetooth-volume-up" & "bluetooth-volume-down". Then send one of these two events after received and parsed AT+VGS sent from remote HS, then it will go through the same path as the user pressing volume up/down button.
Attachment #662402 -
Flags: review?(kyle)
Updated•8 years ago
|
blocking-basecamp: ? → +
Comment 6•8 years ago
|
||
Comment on attachment 662402 [details] [diff] [review] patch 2: v1: adjust volume after receiving AT+VGS Review of attachment 662402 [details] [diff] [review]: ----------------------------------------------------------------- This looks ok to me, but I'm not qualified to review shell.js changes. Adding fabrice.
Attachment #662402 -
Flags: review?(fabrice)
Updated•8 years ago
|
Attachment #662402 -
Flags: review?(kyle) → review+
Comment 7•8 years ago
|
||
Comment on attachment 662402 [details] [diff] [review] patch 2: v1: adjust volume after receiving AT+VGS Review of attachment 662402 [details] [diff] [review]: ----------------------------------------------------------------- I'd rather have a single observer for the topic "bluetooth-volume-change", with "up" and "down" as |data|.
Attachment #662402 -
Flags: review?(fabrice) → feedback+
Assignee | ||
Comment 8•8 years ago
|
||
revised for new unixsocket interface.
Attachment #662393 -
Attachment is obsolete: true
Attachment #664859 -
Flags: review?(kyle)
Assignee | ||
Comment 9•8 years ago
|
||
Changed the name of topic according to Fabrice's comment.
Attachment #662402 -
Attachment is obsolete: true
Updated•8 years ago
|
Attachment #664859 -
Flags: review?(kyle) → review+
Assignee | ||
Comment 10•8 years ago
|
||
try: https://tbpl.mozilla.org/?tree=Try&rev=4552c2414ea6
Assignee | ||
Comment 11•8 years ago
|
||
Attachment #664859 -
Attachment is obsolete: true
Assignee | ||
Comment 12•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/355e9f8b0c67 https://hg.mozilla.org/integration/mozilla-inbound/rev/d76eac692a19
Comment 13•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/355e9f8b0c67 https://hg.mozilla.org/mozilla-central/rev/d76eac692a19
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in
before you can comment on or make changes to this bug.
Description
•