792002 - [b2g-bluetooth] Implement HFP message handler

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Eric Chou [:ericchou] [:echou]]

We need a message handler to establish SLC connection with remote headset and respond to other commands sent from headset.

Reference: Bluetooth Hands-free Profile 1.6

Comment 1

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: v1: HFP message handler, basic functionalities

Basic HFP handler, haven't kept remote device information yet, but it's enough to establish a SLC connection.

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 662132 [details] [diff] [review]
patch 1: v1: HFP message handler, basic functionalities

Review of attachment 662132 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, but same issue, waiting for my socket stuff to land, so delaying my r+ until then. Will put these patches on top of my socket work for testing though. Thanks!

Comment 3

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: v2: HFP message handler, basic functionalities

Comment 4

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: v3: HFP message handler, basic functionalities

Slightly modified comments at the AT+CIND handler. There is a TODO item, and I decided to put this on another issue.

Comment 5

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 2: v1: adjust volume after receiving AT+VGS

To adjust volume and let volume change dialog pop up, first, I make Shell.js listen to topic "bluetooth-volume-up" & "bluetooth-volume-down". Then send one of these two events after received and parsed AT+VGS sent from remote HS, then it will go through the same path as the user pressing volume up/down button.

Comment 6

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 662402 [details] [diff] [review]
patch 2: v1: adjust volume after receiving AT+VGS

Review of attachment 662402 [details] [diff] [review]:
-----------------------------------------------------------------

This looks ok to me, but I'm not qualified to review shell.js changes. Adding fabrice.

Comment 7

[[:fabrice] Fabrice Desré]

Comment on attachment 662402 [details] [diff] [review]
patch 2: v1: adjust volume after receiving AT+VGS

Review of attachment 662402 [details] [diff] [review]:
-----------------------------------------------------------------

I'd rather have a single observer for the topic "bluetooth-volume-change", with "up" and "down" as |data|.

Comment 8

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: v4: Basic functions for observing call status

revised for new unixsocket interface.

Comment 9

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 2: final: adjust volume after receiving AT+VGS, r=qdot, r=fabrice

Changed the name of topic according to Fabrice's comment.

Comment 10

[Eric Chou [:ericchou] [:echou]]

try: https://tbpl.mozilla.org/?tree=Try&rev=4552c2414ea6

Comment 11

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: final: Basic functions for observing call status, r=qdot

Comment 12

[Eric Chou [:ericchou] [:echou]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/355e9f8b0c67
https://hg.mozilla.org/integration/mozilla-inbound/rev/d76eac692a19

Comment 13

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/355e9f8b0c67
https://hg.mozilla.org/mozilla-central/rev/d76eac692a19