Closed Bug 792030 Opened 7 years ago Closed 7 years ago

webConsoleButton.label appears unused, we should remove it

Categories

(DevTools :: Console, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 18

People

(Reporter: jwalker, Assigned: raymondlee)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch v1 (obsolete) — Splinter Review
inspectorButton.label is not being used as well
Attachment #664054 - Flags: review?(jwalker)
Attachment #664054 - Attachment is patch: true
Comment on attachment 664054 [details] [diff] [review]
v1

Review of attachment 664054 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Raymond and well spotted that inspectorButton.label was also unused.

browser.dtd is in a module of which I'm not a peer, so my review isn't really enough. I think I recall asking Tim Taubert the last time I needed a review of browser.dtd. He may be a good person to ask in this case too.
Attachment #664054 - Flags: review?(jwalker) → review+
Attachment #664054 - Flags: review+ → review?(ttaubert)
Attachment #664054 - Flags: review?(ttaubert) → review+
Assignee: nobody → raymond
Status: NEW → ASSIGNED
Attachment #664054 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/38a87696db4f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 18
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.