Allow to precompile startup cache without omnijar'ing first

RESOLVED FIXED in mozilla18

Status

Firefox Build System
General
RESOLVED FIXED
6 years ago
3 months ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla18
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Comment hidden (empty)
(Assignee)

Comment 1

6 years ago
Created attachment 662166 [details] [diff] [review]
Allow to precompile startup cache without omnijar'ing first

This refactors precompile_cache.js to use the resource protocol handler to get the gre and app resource locations, and import all modules and components that can be found in either the corresponding omnijar or directory.

This will allow, in bug 780561, to avoid a two-step packaging, and in bug 755724, to properly precompile cache for both browser and metro without too much hassle.
Attachment #662166 - Flags: review?(khuey)
(Assignee)

Updated

6 years ago
Assignee: nobody → mh+mozilla
(Assignee)

Comment 2

6 years ago
As a bonus, it also removes the import exceptions logs, which are confusing to many people looking at tinderbox logs.
(Assignee)

Updated

6 years ago
Depends on: 792347
(Assignee)

Comment 5

6 years ago
Created attachment 667369 [details] [diff] [review]
Fixup

Interdiff for a fixup to avoid the windows breakage. The problem was that MOZ_STARTUP_CACHE ended up with a path in the form e:/build/something, and NS_NewLocalFile barfs on these (because it expects absolute file names with backslashes).
Attachment #667369 - Flags: review?(khuey)

Comment 7

6 years ago
https://hg.mozilla.org/mozilla-central/rev/305cace7ba51
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18

Updated

3 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.