792060 - about:memory?verbose is unusable on a Galaxy Nexus

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: Screenshot about:memory?verbose

See attached screenshot. When I load about:memory?verbose on my Galaxy Nexus I get the right content but it's so small that it's unreadable. I also cannot zoom in to make the text more readable, presumably because the page has user-scalable=false set in the meta-viewport tag.

Comment 1

[Mark Capella [:capella]]

Attachment: Patch (v1)

Yah, this displays odd on my Galaxy S3 also ... somehow missed the regression when changing approach in the original patch.

I like allowing user-scalable, but it still left the page displayed weird while rotating the screen especially. Changing the CSS (see attached) to match the verbose and non-verbose styles works nicely on my device.

Comment 2

[Mark Capella [:capella]]

Attachment: Screen 1

Comment 3

[Mark Capella [:capella]]

Attachment: Screen 2

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 662509 [details] [diff] [review]
Patch (v1)

Works for me

Comment 5

[Mark Capella [:capella]]

Comment on attachment 662509 [details] [diff] [review]
Patch (v1)

njn ... thoughts / issues here?

Comment 6

[Nicholas Nethercote [inactive]]

Comment on attachment 662509 [details] [diff] [review]
Patch (v1)

Seems fine, thanks.

Comment 7

[Mark Capella [:capella]]

Comment on attachment 662509 [details] [diff] [review]
Patch (v1)

Margaret... see any problems here?

Comment 8

[:Margaret Leibovic]

Comment on attachment 662509 [details] [diff] [review]
Patch (v1)

Review of attachment 662509 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/themes/core/aboutMemory.css
@@ +5,5 @@
>  /* This file is used for both about:memory and about:compartments. */
>  
> +body.verbose pre.entries {
> +  overflow-x: hidden;
> +  text-overflow: ellipsis;

I feel like it would be more useful to just have the text overflow like it does on desktop, since just being able to pan inside the body gives you less visible text. I feel like the ideal thing to do for readability here would be to make the white background expand with the text, but that's also an issue on desktop.

Comment 9

[Mark Capella [:capella]]

Attachment: Patch (v2)

Well, the fix simpler then, (Attached).

I thought not letting the text overflow might be a better presentation for mobile, but being consistent with desktop is a valid concern.

Comment 10

[:Margaret Leibovic]

Comment on attachment 663421 [details] [diff] [review]
Patch (v2)

Thanks. I find panning to be better with this fix, also.

Comment 11

[Mark Capella [:capella]]

TRY push
https://tbpl.mozilla.org/?tree=Try&rev=0945c3a29283

Comment 12

[Mark Capella [:capella]]

Inbound:
http://hg.mozilla.org/integration/mozilla-inbound/rev/091af1edcd98

Comment 13

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/mozilla-central/rev/091af1edcd98

Comment 14

[Ioana Chiorean]

Build ID: 18.0 (2012-10-08) Nightly Channel
          19.0 (2012-10-09) Nightly Channel
Device: Samsung Galaxy Nexus
OS: Android 4.1

The page is loaded zoomed in. The text is readable and can be panned and zoomed in/out.

Marking bug as Verify Fixed.