Closed Bug 792109 Opened 11 years ago Closed 11 years ago

Generate an outmix per opensl cubeb context, not stream

Categories

(Core :: Audio/Video, defect)

Product:
Core
Component:
Audio/Video
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla18

People

(Reporter: mwu, Assigned: mwu)

References

Details

Attachments

(1 file)

Make outmixs per context, not stream
4.28 KB, patch
kinetik
: review+
Details | Diff | Splinter Review 
This is a small optimization to reduce the number of output mix objects we allocate.
Attachment #662216 - Flags: review?(kinetik)
Comment on attachment 662216 [details] [diff] [review]
Make outmixs per context, not stream

Is the pref change intentional?  If so, we can just drop the ifdef MOZ_WIDGET_GONK altogether.
Attachment #662216 - Flags: review?(kinetik) → review+
(In reply to Matthew Gregan [:kinetik] from comment #1)
> Comment on attachment 662216 [details] [diff] [review]
> Make outmixs per context, not stream
> 
> Is the pref change intentional?  If so, we can just drop the ifdef
> MOZ_WIDGET_GONK altogether.

Uhh, not at all actually, I just forgot to sanitize this patch before uploading. Thanks for pointing that out - I might've committed it.
https://hg.mozilla.org/integration/mozilla-inbound/rev/bd797fec462d
Target Milestone: --- → mozilla18
I backed out a range of patches including this one which caused a perma-leak in all of our test suites on debug builds:

https://hg.mozilla.org/integration/mozilla-inbound/rev/e60144694d56
https://hg.mozilla.org/mozilla-central/rev/d7c22610380a
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.