792133 - add a button "Open Logs" linking to sync logs from about:support

Status: NEW

(Firefox :: Sync, defect)

Description

[Allison Naaktgeboren :ally]

follow up from 

https://bugzilla.mozilla.org/show_bug.cgi?id=720997#c11

Comment 1

[Allison Naaktgeboren :ally]

might as well finish what I started.

Comment 2

[Allison Naaktgeboren :ally]

mconnor, gps, rnewman: my plan is to add it under the Firefox Sync section, modeled after the "Profile Folder| Show in Finder" button. 

Do we want to link them to directory of logs or the about:sync-log page?

Comment 3

[Richard Newman [:rnewman]]

(In reply to :Ally Naaktgeboren from comment #2)
> mconnor, gps, rnewman: my plan is to add it under the Firefox Sync section,
> modeled after the "Profile Folder| Show in Finder" button. 

wfm.

> Do we want to link them to directory of logs or the about:sync-log page?

Might as well do the latter.

Comment 4

[Allison Naaktgeboren :ally]

mconnor thinks a button next to the title (of 720997) would be better. gps has no strong opinions.

Blair, opinions?

Comment 5

[Allison Naaktgeboren :ally]

Attachment: screen shot with button next to title

screenshot of the button next to header.

Comment 6

[Gregory Szorc [:gps]]

Comment on attachment 662729 [details]
screen shot with button next to title

Nit: While the default is to record only error logs, not all logs may be from errors. I think "Open Logs" is a more appropriate label.

Comment 7

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to :Ally Naaktgeboren from comment #4)
> mconnor thinks a button next to the title (of 720997) would be better. gps
> has no strong opinions.
> 
> Blair, opinions?

I guess it doesn't really fit under "Application basics". So yea, beside the Sync heading WFM.

And what gps said.

Comment 8

[Allison Naaktgeboren :ally]

sgtm

Comment 9

[Allison Naaktgeboren :ally]

Attachment: v0, part 1

Comment 10

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Any update on bug 720997? Been waiting to see the revised patch for that before reviewing this.

Comment 11

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 669195 [details] [diff] [review]
v0, part 1

Clearing review, see comment 10.

Comment 12

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 13

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 14

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.