Closed
Bug 792157
Opened 13 years ago
Closed 13 years ago
Update callers in SeaMonkey code to reflect changes in nsIFaviconService
Categories
(SeaMonkey :: General, defect)
SeaMonkey
General
Tracking
(seamonkey2.15 fixed)
RESOLVED
FIXED
seamonkey2.15
| Tracking | Status | |
|---|---|---|
| seamonkey2.15 | --- | fixed |
People
(Reporter: mcsmurf, Assigned: mcsmurf)
References
Details
Attachments
(1 file)
|
1.78 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
Bug 741059 changed the nsIFaviconService and the mozIAsyncFavicons interface. We need to update our code to reflect those changes.
|
||
Comment 1•13 years ago
|
||
Right. This is what you get (compiled a build myself):
Error: NS_ERROR_XPC_NOT_ENOUGH_ARGS: Not enough arguments [mozIAsyncFavicons.setAndFetchFaviconForPage]
Source File: chrome://navigator/content/tabbrowser.xml
Line: 705
m-c changeset: http://hg.mozilla.org/mozilla-central/rev/89027f6e7662
"Bug 741059 - Part 4: Update the callers to mozIAsyncFavicon::SetAndFetchFaviconForPage"
Non-shared files:
* browser/base/content/tabbrowser.xml
* browser/components/feeds/src/FeedWriter.js
|
|
||
Comment 2•13 years ago
|
||
Us: http://mxr.mozilla.org/comm-central/search?string=setAndFetchFaviconForPage&find=%2Fsuite%2F
TB: Covered in bug 792105 (specialTabs.js which we don't have).
|
Assignee | |
Comment 4•13 years ago
|
||
|
||
Comment 5•13 years ago
|
||
Comment on attachment 662273 [details] [diff] [review]
Patch
Sorry for forgetting SM! :(
Attachment #662273 -
Flags: review?(neil) → review+
|
||
Comment 6•13 years ago
|
||
Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/f97bbaa649d5
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
status-seamonkey2.15:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.15
You need to log in
before you can comment on or make changes to this bug.
Description
•