792181 - Suppress all WN pages for updates to FF16 (and only 16)

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Alex Keybl [:akeybl]]

We need to suppress all WN pages for updates to FF16 (and only 16) due to bug 789422, which will be first "fixed" in the update from FF16->FF17 (although the code is already in FF16).

Comment 1

[Robert Strong (they/them - no direct email)]

Questions from email for this bug

I am fairly certain that it would suppress all WN pages for that version. Is that ok?

Regarding assigning it to me, when do you need this by?

Comment 2

[Robert Strong (they/them - no direct email)]

Answers

(In reply to Robert Strong [:rstrong] (do not email) from comment #1)
> Questions from email for this bug
> 
> I am fairly certain that it would suppress all WN pages for that version. Is
> that ok?
Yep - that'd be great. As long as 16->17 isn't suppressed (we may want a WN page there).

> 
> Regarding assigning it to me, when do you need this by?
Next Tuesday would be the beta 5 go to build, so it'd be great to get it into the build prior.

Comment 3

[Robert Strong (they/them - no direct email)]

Also, since this will only be needed on the Firefox 16 train it only needs to land there.

Comment 4

[Robert Strong (they/them - no direct email)]

Attachment: Patch rev1 - tested - beta branch only

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Is getPostUpdateOverridePage garanteed to be called in all cases? Wouldn't it be safer to also remove the values of the startup.homepage* prefs?

http://mxr.mozilla.org/mozilla-beta/source/browser/branding/official/pref/firefox-branding.js#5

Comment 6

[Robert Strong (they/them - no direct email)]

to be honest, if I were to go with a "safer" method I would prefer to do it with code removal and not with pref removal.

I'll stop my other work on the stub installer and dive further into this to make doubly sure.

Comment 7

[Robert Strong (they/them - no direct email)]

Attachment: patch rev2

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 664253 [details] [diff] [review]
patch rev2

yeah, this is exactly what I had in mind

Comment 9

[Robert Strong (they/them - no direct email)]

Comment on attachment 664253 [details] [diff] [review]
patch rev2

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 307181
User impact if declined: user's will see the what's new page after an update
Testing completed (on m-c, etc.): manual testing.
Risk to taking this patch (and alternatives if risky): minimal risk.
String or UUID changes made by this patch: none

Comment 10

[Alex Keybl [:akeybl]]

Comment on attachment 664253 [details] [diff] [review]
patch rev2

[Triage Comment]
Thanks for the one off patch and r+ guys. FF16 will be silent!

Comment 11

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-beta
https://hg.mozilla.org/releases/mozilla-beta/rev/4b3d0a8a38cd

Comment 12

[Phil Ringnalda (:philor)]

permaoranged browser_bug538331.js.

Comment 13

[Robert Strong (they/them - no direct email)]

Thanks, I should have realized that would happen with the removal of the code it tests. :(

Comment 14

[Robert Strong (they/them - no direct email)]

Attachment: Don't run test

Comment 15

[Robert Strong (they/them - no direct email)]

Pushed test fix for permaorange.
https://hg.mozilla.org/releases/mozilla-beta/rev/36dc6a850935

Comment 16

[Robert Strong (they/them - no direct email)]

Comment on attachment 664324 [details] [diff] [review]
Don't run test

got an rs=dolske over irc

Comment 17

[Simona Badau]

Verified that the "What's new page" is suppressed when updating to Firefox 16 beta 6 (used the test case from Comment 22 - Bug 789422). 

Verified on Windows 7, Ubuntu 12.04 and Mac OS X 10.7:
Mozilla/5.0 (Windows NT 5.1; rv:16.0) Gecko/20100101 Firefox/16.0
Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20100101 Firefox/16.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:16.0) Gecko/20100101 Firefox/16.0

Comment 18

[Tracy Walker [:tracy]]

mass remove verifyme requests greater than 4 months old