Closed Bug 792181 Opened 7 years ago Closed 7 years ago

Suppress all WN pages for updates to FF16 (and only 16)

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 16
Tracking Flags:
Tracking Status
firefox15 --- wontfix
firefox16 --- verified
firefox17 --- unaffected
firefox18 --- unaffected
firefox-esr10 --- unaffected

People

(Reporter: akeybl, Assigned: robert.strong.bugs)

Details

Attachments

(2 files, 1 obsolete file)

patch rev2
3.05 KB, patch
Gavin
: review+
akeybl
: approval-mozilla-beta+
Details | Diff | Splinter Review
Don't run test
438 bytes, patch
robert.strong.bugs
: review+
Details | Diff | Splinter Review 
We need to suppress all WN pages for updates to FF16 (and only 16) due to bug 789422, which will be first "fixed" in the update from FF16->FF17 (although the code is already in FF16).
Questions from email for this bug

I am fairly certain that it would suppress all WN pages for that version. Is that ok?

Regarding assigning it to me, when do you need this by?
Answers

(In reply to Robert Strong [:rstrong] (do not email) from comment #1)
> Questions from email for this bug
> 
> I am fairly certain that it would suppress all WN pages for that version. Is
> that ok?
Yep - that'd be great. As long as 16->17 isn't suppressed (we may want a WN page there).

> 
> Regarding assigning it to me, when do you need this by?
Next Tuesday would be the beta 5 go to build, so it'd be great to get it into the build prior.
Also, since this will only be needed on the Firefox 16 train it only needs to land there.
Attachment #664237 - Attachment description: Patch rev1 - untested → Patch rev1 - tested - beta branch only
Attachment #664237 - Flags: review?(ehsan) → review+
Is getPostUpdateOverridePage garanteed to be called in all cases? Wouldn't it be safer to also remove the values of the startup.homepage* prefs?

http://mxr.mozilla.org/mozilla-beta/source/browser/branding/official/pref/firefox-branding.js#5
to be honest, if I were to go with a "safer" method I would prefer to do it with code removal and not with pref removal.

I'll stop my other work on the stub installer and dive further into this to make doubly sure.
Attached patch patch rev2 — — Splinter Review
Attachment #664237 - Attachment is obsolete: true
Attachment #664253 - Flags: review?(gavin.sharp)
Comment on attachment 664253 [details] [diff] [review]
patch rev2

yeah, this is exactly what I had in mind
Attachment #664253 - Flags: review?(gavin.sharp) → review+
Comment on attachment 664253 [details] [diff] [review]
patch rev2

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 307181
User impact if declined: user's will see the what's new page after an update
Testing completed (on m-c, etc.): manual testing.
Risk to taking this patch (and alternatives if risky): minimal risk.
String or UUID changes made by this patch: none
Attachment #664253 - Flags: approval-mozilla-beta?
Comment on attachment 664253 [details] [diff] [review]
patch rev2

[Triage Comment]
Thanks for the one off patch and r+ guys. FF16 will be silent!
Attachment #664253 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Pushed to mozilla-beta
https://hg.mozilla.org/releases/mozilla-beta/rev/4b3d0a8a38cd
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox16: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
permaoranged browser_bug538331.js.
Thanks, I should have realized that would happen with the removal of the code it tests. :(
Comment on attachment 664324 [details] [diff] [review]
Don't run test

got an rs=dolske over irc
Attachment #664324 - Flags: review?(gavin.sharp) → review+
Keywords: verifyme
Verified that the "What's new page" is suppressed when updating to Firefox 16 beta 6 (used the test case from Comment 22 - Bug 789422). 

Verified on Windows 7, Ubuntu 12.04 and Mac OS X 10.7:
Mozilla/5.0 (Windows NT 5.1; rv:16.0) Gecko/20100101 Firefox/16.0
Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20100101 Firefox/16.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:16.0) Gecko/20100101 Firefox/16.0
status-firefox16: fixed → verified
mass remove verifyme requests greater than 4 months old
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.