792205 - Ratio totals for Crashes per ADU by O/S are incorrect

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Matt Brandt [:mbrandt]]

Attachment: qa - screenhot of defect

Steps to reproduce:
1. goto Crashes per ADU by O/S
2. generate a report
3. view ratio totals for the different operating systems in the Crashes per ADU table.

Expected:
The ratio totals are correctly summed

Actual:
The ratio totals are incorrect - see screenshot

Comment 1

[Robert Kaiser]

IMHO, we should not change this for the PHP UI; but remove this "Total" row completely in the python version. The "Totals" row on /daily is pretty useless, actually.

Comment 2

[Laura Thomson :laura]

I propose moving this bug over to socorro-crashstats then (the Python version). OK by you, Kairo?

Comment 3

[Robert Kaiser]

(In reply to Laura Thomson :laura from comment #2)
> I propose moving this bug over to socorro-crashstats then (the Python
> version). OK by you, Kairo?

I think that's what I said in comment #1, so yes. :)

Comment 5

[Robert Kaiser]

BTW, if someone's add it, could we please remove the % sign from the crash rate column? This is crashes per 100 ADI, so it's a value that has a unit assigned to it and therefore cannot be a percentage. The scientist in me always cringes when seeing that % sign wrongly attached to those values...

Comment 6

[Peter Bengtsson [:peterbe]]

Attachment: Screen Shot 2013-08-20 at 12.50.55 PM.png

Is this what you expect to see instead?

Comment 7

[Peter Bengtsson [:peterbe]]

In case my screenshot does the right thing, here's the PR
https://github.com/mozilla/socorro/pull/1420

Comment 8

[Robert Kaiser]

Comment on attachment 793034 [details]
Screen Shot 2013-08-20 at 12.50.55 PM.png

Yes, this looks awesome!

Comment 9

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/5600f4f2449d91e3f2f26a107685a2e35122ccbd
fixes bug 792205 - Ratio totals for Crashes per ADU by O/S are incorrect, r=KaiRo-at

Comment 10

[Matt Brandt [:mbrandt]]

Marking as awesome and verified per comment 8.

Independent verification done as well on stage - https://crash-stats.allizom.org/daily?p=Firefox