792345 - [b2g-bluetooth] Handle call status change

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Eric Chou [:ericchou] [:echou]]

In order to notify HS of call status change, we need to implement an listener to observe call status change.

Comment 1

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: v1: Basic functions for observing call status

Implementation of call status observer. Please note that "StartListening()" hasn't been called yet.

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 662476 [details] [diff] [review]
patch 1: v1: Basic functions for observing call status

Review of attachment 662476 [details] [diff] [review]:
-----------------------------------------------------------------

We should probably add checks for MOZ_B2G_RIL around the additions to the makefile, and at any place we might need to access the RIL. Idea looks decent though, only reason the r- is there is because MOZ_B2G_BT doesn't necessarily assume MOZ_B2G_RIL.

::: dom/bluetooth/BluetoothRilListener.cpp
@@ +62,5 @@
> +
> +bool
> +BluetoothRilListener::StartListening()
> +{
> +  nsCOMPtr<nsIRILContentHelper> ril = do_GetService(NS_RILCONTENTHELPER_CONTRACTID);

You should check for service validity here.

Comment 3

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: v2: Basic functions for observing call status

Added MOZ_B2G_RIL check to Makefile & checked service availability.

Comment 4

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 2: v1: implement CallStateChanged

Followed spec to implement CallStateChanged function. Created a runnable for sending RING indicator every 3 seconds.

Comment 5

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: v2: Basic functions for observing call status

Added MOZ_B2G_RIL check to Makefile & checked service availability.

Comment 6

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 662804 [details] [diff] [review]
patch 2: v1: implement CallStateChanged

Review of attachment 662804 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bluetooth/BluetoothHfpManager.cpp
@@ +206,5 @@
>    SendSocketData(new mozilla::ipc::SocketRawData(msg.get()));
>  }
>  
> +/*
> + * CallStateChanged will be called whenever call status is changed, and it 

Nit: space at end of line

Comment 7

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 662805 [details] [diff] [review]
patch 1: v2: Basic functions for observing call status

Review of attachment 662805 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bluetooth/BluetoothRilListener.cpp
@@ +64,5 @@
> +BluetoothRilListener::StartListening()
> +{
> +  nsCOMPtr<nsIRILContentHelper> ril = do_GetService(NS_RILCONTENTHELPER_CONTRACTID);
> +  if (!ril) {
> +    NS_ERROR("No RIL Service!"); 

Nit: space at end of line

@@ +77,5 @@
> +bool
> +BluetoothRilListener::StopListening()
> +{
> +  nsCOMPtr<nsIRILContentHelper> ril = do_GetService(NS_RILCONTENTHELPER_CONTRACTID);
> +   if (!ril) {

Nit: indentation

@@ +78,5 @@
> +BluetoothRilListener::StopListening()
> +{
> +  nsCOMPtr<nsIRILContentHelper> ril = do_GetService(NS_RILCONTENTHELPER_CONTRACTID);
> +   if (!ril) {
> +    NS_ERROR("No RIL Service!"); 

Nit: space at end of line

::: dom/bluetooth/Makefile.in
@@ +40,5 @@
>    $(NULL)
>  
> +ifdef MOZ_B2G_RIL
> +CPPSRCS += BluetoothRilListener.cpp \
> +  $(NULL)

Nit: Don't need the \ $(NULL)

Comment 8

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: final: Basic functions for observing call status, r=qdot

nits picked.

Comment 9

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 2: final: Implemented CallStateChanged, r=qdot

Nit picked.

Comment 10

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 2: final: Implemented CallStateChanged, r=qdot

NS_WARNING can only be passed one parameter.

Comment 11

[Eric Chou [:ericchou] [:echou]]

try : https://tbpl.mozilla.org/?tree=Try&rev=9dc836798466

Comment 12

[Eric Chou [:ericchou] [:echou]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8bf5132fa243
https://hg.mozilla.org/integration/mozilla-inbound/rev/9b839b6340fe

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8bf5132fa243
https://hg.mozilla.org/mozilla-central/rev/9b839b6340fe