792346 - Image assets section is not updated with the previous uploaded image when edited

Status: VERIFIED FIXED

(Marketplace Graveyard :: Developer Pages, defect)

Description

[Cristian Boldan]

Steps to reproduce:
1. Load MP Dev Hub ( https://marketplace-dev.allizom.org/developers/ )
2. Click on Edit Listing link from a listed app.
3. Edit the Media section.
4. Change both Desktop and Mobile Tile images from the Image Assets section.
5. Save changes.
6. Click Edit on the Media section again.

Expected results:
The uploaded images are displayed when user is in preview or edit mode for the Media section.

Actual results:
The old images appear in edit mode, even after new images were uploaded and saved for the Image Assets section.

Notes/Issues:
Verified in FF18 (Win 7). Issue is also reproducing in production.
Screencast for this issue http://screencast.com/t/2LYnvrLie

Comment 1

[Matt Basta [:basta]]

This happens because we don't cache bust the images in the edit view. Opening the images in a new tab and refreshing them will show the updated images.

Comment 2

[Matt Basta [:basta]]

Fixed:

https://github.com/mozilla/zamboni/commit/ad6ae2721b2e6fa1193fab13870e5d7674d1ae86

Comment 3

[Cristian Boldan]

Issue is still reproducing in https://marketplace-dev.allizom.org/ on FF18 (Win 7)
Screencast for this issue http://screencast.com/t/QvbO0mfv0D

Comment 4

[Matt Basta [:basta]]

https://github.com/mozilla/zamboni/commit/dc92a6d4da2f558678ccfd1d882583363268def1

Comment 5

[krupa raj[:krupa]]

STR:
1. Load
2. Click "Edit" on Media
3. Add new image assets for both mobile and desktop
4. Save changes
5. Notice that the new images are shown
6. Click on "Edit" again

Expected behavior:
New images which were uploaded are shown on clicking "Edit"

Actual behavior:
on clicking again, we revert to showing the old image assets.



screencast: http://screencast.com/t/z4eDWPElol2

Comment 6

[krupa raj[:krupa]]

(In reply to krupa raj 82[:krupa] from comment #5)
> STR:
> 1. Load
> 2. Click "Edit" on Media
> 3. Add new image assets for both mobile and desktop
> 4. Save changes
> 5. Notice that the new images are shown
> 6. Click on "Edit" again
> 

1. Load https://marketplace.mozilla.org/developers/app/test-app-bear1085/edit

Comment 7

[krupa raj[:krupa]]

comment 5 and 6 exist as proof of my stupidity. This works fine on -dev. Sorry basta for questioning your fix :)

Comment 8

[Cristian Boldan]

Verified as fixed on https://marketplace-dev.allizom.org/developers/ in FF18 (Win 7).
Postfix screencast http://screencast.com/t/whnyqlrL
Closing bug.