Make it possible to build the Metro UI on non-Windows platforms

RESOLVED FIXED

Status

Product:
Firefox for Metro Graveyard
Component:
General
Type:
defect
Status:
RESOLVED FIXED
Opened:
7 years ago
Updated:
5 years ago

People

(Reporter: mbrubeck, Assigned: mbrubeck)

Tracking

Version:
Trunk
Platform:
All
Windows 8.1
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [completed-elm])

Attachments

(1 attachment, 1 obsolete attachment)

patch v2
8.85 KB, patch
jimm
: review+
Details | Diff | Splinter Review
Posted patch patch (obsolete) — — Splinter Review 
Building and running in -metrodesktop mode on Linux or Mac might be useful to Firefox contributors or add-on developers who want to try out something in Metro Firefox but don't have convenient access to a Window development box.
Attachment #662648 - Flags: review?(jmathies)
Posted patch patch v2 — — Splinter Review 
Restore some lines that I shouldn't have removed.
Attachment #662648 - Attachment is obsolete: true
Attachment #662648 - Flags: review?(jmathies)
Attachment #662649 - Flags: review?(jmathies)
Comment on attachment 662649 [details] [diff] [review]
patch v2

Review of attachment 662649 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me!

::: browser/metro/base/content/browser-scripts.js
@@ +33,5 @@
>  XPCOMUtils.defineLazyServiceGetter(this, "MetroUtils",
>                                     "@mozilla.org/windows-metroutils;1",
>                                     "nsIWinMetroUtils");
> +#else
> +// Stub nsIWinMetroUtils implementation for testing on non-Windows platforms:

Might want to add a note in nsIWinMetroUtils about this being here.
Attachment #662649 - Flags: review?(jmathies) → review+
Pushed with added comment and rebased to deal with bug 771271:
https://hg.mozilla.org/projects/elm/rev/b8f56dbcec24
Whiteboard: [completed-elm]
Depends on: 797533
Product: Firefox → Firefox for Metro
Version: unspecified → Trunk
Re-landed a hunk that was accidentally reverted in a merge:
https://hg.mozilla.org/projects/elm/rev/73ab012e69bc
https://hg.mozilla.org/mozilla-central/rev/7a6aae4391df
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Depends on: 944937
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.