792509 - Make it possible to build the Metro UI on non-Windows platforms

Status: RESOLVED FIXED

Description

[Matt Brubeck (:mbrubeck)]

Created attachment 662648 [details] [diff] [review]
patch

Building and running in -metrodesktop mode on Linux or Mac might be useful to Firefox contributors or add-on developers who want to try out something in Metro Firefox but don't have convenient access to a Window development box.

Comment 1

[Matt Brubeck (:mbrubeck)]

Created attachment 662649 [details] [diff] [review]
patch v2

Restore some lines that I shouldn't have removed.

Comment 2

[Jim Mathies [:jimm]]

Comment on attachment 662649 [details] [diff] [review]
patch v2

Review of attachment 662649 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me!

::: browser/metro/base/content/browser-scripts.js
@@ +33,5 @@
>  XPCOMUtils.defineLazyServiceGetter(this, "MetroUtils",
>                                     "@mozilla.org/windows-metroutils;1",
>                                     "nsIWinMetroUtils");
> +#else
> +// Stub nsIWinMetroUtils implementation for testing on non-Windows platforms:

Might want to add a note in nsIWinMetroUtils about this being here.

Comment 3

[Matt Brubeck (:mbrubeck)]

Pushed with added comment and rebased to deal with bug 771271:
https://hg.mozilla.org/projects/elm/rev/b8f56dbcec24

Comment 4

[Matt Brubeck (:mbrubeck)]

Re-landed a hunk that was accidentally reverted in a merge:
https://hg.mozilla.org/projects/elm/rev/73ab012e69bc

Comment 5

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7a6aae4391df

Comment 6

[Phil Ringnalda (:philor)(back in August)]

https://hg.mozilla.org/mozilla-central/rev/7a6aae4391df