Closed
Bug 792509
Opened 13 years ago
Closed 12 years ago
Make it possible to build the Metro UI on non-Windows platforms
Categories
(Firefox for Metro Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mbrubeck, Assigned: mbrubeck)
References
Details
(Whiteboard: [completed-elm])
Attachments
(1 file, 1 obsolete file)
8.85 KB,
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
Building and running in -metrodesktop mode on Linux or Mac might be useful to Firefox contributors or add-on developers who want to try out something in Metro Firefox but don't have convenient access to a Window development box.
Attachment #662648 -
Flags: review?(jmathies)
Assignee | ||
Comment 1•13 years ago
|
||
Restore some lines that I shouldn't have removed.
Attachment #662648 -
Attachment is obsolete: true
Attachment #662648 -
Flags: review?(jmathies)
Attachment #662649 -
Flags: review?(jmathies)
![]() |
||
Comment 2•13 years ago
|
||
Comment on attachment 662649 [details] [diff] [review]
patch v2
Review of attachment 662649 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me!
::: browser/metro/base/content/browser-scripts.js
@@ +33,5 @@
> XPCOMUtils.defineLazyServiceGetter(this, "MetroUtils",
> "@mozilla.org/windows-metroutils;1",
> "nsIWinMetroUtils");
> +#else
> +// Stub nsIWinMetroUtils implementation for testing on non-Windows platforms:
Might want to add a note in nsIWinMetroUtils about this being here.
Attachment #662649 -
Flags: review?(jmathies) → review+
Assignee | ||
Comment 3•13 years ago
|
||
Pushed with added comment and rebased to deal with bug 771271:
https://hg.mozilla.org/projects/elm/rev/b8f56dbcec24
Whiteboard: [completed-elm]
![]() |
||
Updated•13 years ago
|
Product: Firefox → Firefox for Metro
Version: unspecified → Trunk
Assignee | ||
Comment 4•12 years ago
|
||
Re-landed a hunk that was accidentally reverted in a merge:
https://hg.mozilla.org/projects/elm/rev/73ab012e69bc
Assignee | ||
Comment 5•12 years ago
|
||
Comment 6•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
OS: Windows 8 Metro → Windows 8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•