Closed
Bug 792685
Opened 12 years ago
Closed 12 years ago
Add a way to have automagically inherited variable definitions in Makefiles
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla18
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
|
3.98 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #662843 -
Flags: review?(ted.mielczarek)
|
|
Assignee | |
Comment 2•12 years ago
|
||
The usecase is for bug 755724, where we can just define DIST_SUBDIR=browser in browser/defs.mk, and DIST_SUBDIR=metro in browser/metro/defs.mk.
|
||
Comment 3•12 years ago
|
||
Comment on attachment 662843 [details] [diff] [review]
Add a way to have automagically inherited variable definitions in Makefiles
Review of attachment 662843 [details] [diff] [review]:
-----------------------------------------------------------------
::: config/config.mk
@@ +27,5 @@
> include $(DEPTH)/config/autoconf.mk
> endif
>
> +nullstr :=
> +space :=$(nullstr) # EOL
You can ostensibly just use $(NULL) here right?
@@ +39,5 @@
> +__depth := $(subst /, ,$(DEPTH))
> +ifeq (.,$(__depth))
> +__depth :=
> +endif
> +$(foreach __d,$(__depth) .,$(eval __depth = $(wordlist 2,$(words $(__depth)),$(__depth))$(eval -include $(subst $(space),/,$(strip $(srcdir) $(__depth) defs.mk)))))
This hurts my head, but ok.
Attachment #662843 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•