792795 - Log in is not working in Developer Hub

Status: VERIFIED FIXED

(Marketplace Graveyard :: Developer Pages, defect)

Description

[Cristian Boldan]

Steps to reproduce:
1. Load MP Dev Hub https://marketplace-dev.allizom.org/developers/
2. Click the Log in/Register link or the "Submit an App" button
3. Log in with Browser ID and click the "sign in" button.

Expected results:
User is logged in.

Actual results:
Nothing happens.

Notes/Issues:
Verified in FF18 (Win 7).
Screencast for this issue http://screencast.com/t/K8wk2apim

Comment 1

[Christopher Van Wiemeersch [:cvan]]

I'm on Firefox Nightly 18.0a1 (2012-09-14) and Chrome 21.0.1180.89 on Mac OS X 10.6.7. I've been able to log in just fine via the "Log in/Register" link and the "Submit an App" button. Are there any JS errors in the console for you?

Comment 2

[Jen Fong-Adwent [:ednapiranha]]

I can't reproduce the issue - tested Nightly and Chrome also on Mac OS X.

Comment 3

[Wil Clouser [:clouserw]]

closing due to comment 1 and comment 2

Comment 4

[Cristian Boldan]

Verified as fixed in https://marketplace-dev.allizom.org/developers/ on FF19 (Win 7).
Postfix screencast http://screencast.com/t/V54bCIOOV
Closing bug.

Comment 5

[Cristian Boldan]

Issue is reproducing again in https://marketplace-dev.allizom.org/developers/
Please see screencast http://screencast.com/t/W0Ipc6ZW

Comment 6

[Florin Strugariu [:Bebe]]

In our automated test we get redirected to consumer-pages 
http://www.screencast.com/t/DvDv3zn8OW2

it started failing with Build #93 (Oct 17, 2012 12:47:32 AM) 
http://qa-selenium.mv.mozilla.com:8080/job/marketplace.dev.developer_hub/93/

Comment 7

[Wraithan (Chris McDonald) [:wraithan]]

I can also reproduce this, was tricky at first though because logout didn't want to stick (I'll open a bug for that too).

1) Make sure you are completely logged out (refresh developers page and/or check consumer page)
2) Open web console and log response bodies.
3) Click log in/register on https://marketplace-dev.allizom.org/developers/
4) Notice that you get a 403 for https://marketplace-dev.allizom.org/users/browserid-login with a body like:

<div class="">
    <section class="primary">
      <h2>Oops! Not allowed.</h2>
      <p>You tried to do something that you weren't allowed to.</p>
          <p>Try going back to the previous page, refreshing and trying again.</p>
      </section>
</div>

5) Refresh page, note how you are logged in.

Comment 8

[JR Conlin [:jrconlin,:jconlin]]

Looks like AMO and MKT overlap in horrible ways.

The problem is that this template loads both the AMO browserid_support.js file and MKT's login.js files. The problem is that AMO is a bit more aggressive about getting the redirect location. 

Going to try to align both so that they have the same behaviors.

Comment 9

[Florin Strugariu [:Bebe]]

This is blocking our selenium automation build can we make it a priority

http://qa-selenium.mv.mozilla.com:8080/job/marketplace.dev.developer_hub/

Comment 10

[JR Conlin [:jrconlin,:jconlin]]

Pull request merged 2012-10-22
https://github.com/mozilla/zamboni/pull/470

Comment 11

[Wil Clouser [:clouserw]]

(In reply to JR Conlin [:jrconlin,:jconlin] from comment #10)
> Pull request merged 2012-10-22
> https://github.com/mozilla/zamboni/pull/470

I'm assuming that closes this

Comment 12

[Florin Strugariu [:Bebe]]

The issue is still reproducing...
After the browser id windows is gone a spinner is visible and that is it...

http://www.screencast.com/t/O4sGyxoTd0

Comment 13

[Florin Strugariu [:Bebe]]

If you refresh the page the user is logged in...

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

JR, can you please take another look at this?

Comment 15

[Matt Basta [:basta]]

This bug is happening because /users/browserid-login is returning a 403. The user is being authenticated on the server side, but the AJAX callback to verify the assertion is a 4xx error, which login.js interprets as meaning that the user was not logged in. No error message is being displayed because the box that otherwise would display the error in the consumer pages isn't present in the devhub (and the jQuery bits that login.js uses fail silently).

Comment 16

[Matt Basta [:basta]]

So I thought it was weird that browserid-login was failing on /developers and not anywhere else. As a means of debugging, I took the diff of the HTTP request headers to see what differentiates the two. Here are the results:

From /developers:

Cookie  WT_FPC=id=63.245.220.240-2592289488.30151897:lv=1351324128982:ss=1351323991304; lang="en-US\054"; region=us; sessionid=58208fa8719c803c3cef564144811fff; multidb_pin_writes=y
Referer https://marketplace-dev.allizom.org/developers/?debug=true


From /:

Cache-Control   no-cache
Connection  keep-alive
Cookie  WT_FPC=id=63.245.220.240-2592289488.30151897:lv=1351324408765:ss=1351323991304; lang="en-US\054"; region=us; sessionid=277281b8bcc90697790cdac0949f4283
Pragma  no-cache
Referer https://marketplace-dev.allizom.org/?debug=true


Everything else is the same. Somewhere along the way, our browserid code is choking on one of those headers and throwing a 403.

Comment 17

[Stephen Donner [:stephend] Not actively reading bugmail]

Basta fixed this with https://github.com/mozilla/zamboni/commit/897e4ed80b407e5048dbd65ea395c811ebf94da3

Tests, since: http://qa-selenium.mv.mozilla.com:8080/job/marketplace.dev.developer_hub/115/

Comment 18

[JR Conlin [:jrconlin,:jconlin]]

Sorry, just caught up on the flood and saw this. 

Yes, login.js is better suited for Market and browserid_support.js is better suited for AMO. Ideally, there should be just one library for both, but there are some extra bits that need to be set for AMO.

Thanks basta.

Comment 19

[Florin Strugariu [:Bebe]]

our tests started to pass
Thanks for the hard work all
http://qa-selenium.mv.mozilla.com:8080/job/marketplace.dev.developer_hub/115/